+1 (non-binding) Here are some places in the code base we would need to update. https://grep.app/search?q=dist.apache.org/repos/dist/.%2A/iceberg/KEYS®exp=true I also double-checked against the "/KEYS" search, seems like we've captured all the necessary changes above https://grep.app/search?q=/KEYS&case=true&filter[repo.pattern][0]=iceberg
Best, Kevin Liu On Mon, Nov 11, 2024 at 9:45 AM Matt Topol <zotthewiz...@gmail.com> wrote: > +1 (non-binding) for merging, I can update the docs on the iceberg Go > release README after it's done! > > On Mon, Nov 11, 2024, 12:20 PM Yufei Gu <flyrain...@gmail.com> wrote: > >> +1 merging sounds good. It should still work for previous releases. >> >> Yufei >> >> >> On Mon, Nov 11, 2024 at 7:46 AM Xuanwo <xua...@apache.org> wrote: >> >>> Hi >>> >>> Thank you, Fokko, for proposing this. Here is my +1, non-binding. >>> >>> I'd also like to mention that as part of the ASF release policy, we must >>> refer to "https://downloads.apache.org/iceberg/KEYS"; for KEYS; other >>> links are not allowed. >>> >>> Ref: https://infra.apache.org/release-download-pages.html#links >>> >>> On Mon, Nov 11, 2024, at 23:32, Russell Spitzer wrote: >>> >>> Sounds good to me, although I guess it's really just up to the Rust and >>> GO maintainers to converge >>> >>> On Mon, Nov 11, 2024 at 9:13 AM Fokko Driesprong <fo...@apache.org> >>> wrote: >>> >>> Hi everyone, >>> >>> While looking at the release steps for iceberg-go >>> <https://github.com/apache/iceberg-go/tree/main/dev/release>, I noticed >>> that we have two KEYS files: >>> >>> - https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>> - https://dist.apache.org/repos/dist/release/iceberg/KEYS (Also >>> available through https://downloads.apache.org/iceberg/KEYS) >>> >>> The first one is referenced by Java >>> <https://iceberg.apache.org/how-to-release/#setup> and Python >>> <https://py.iceberg.apache.org/verify-release/#verifying-signatures>, >>> and the last one by Rust <https://rust.iceberg.apache.org/release.html>. >>> As mentioned earlier, Go references them both. Should we consolidate these? >>> My suggestion would be to merge the `/dev/` ones into the `release` ones, >>> and get rid of the one in `dev`. Thoughts? >>> >>> Kind regards, >>> Fokko >>> >>> Xuanwo >>> >>> https://xuanwo.io/ >>> >>>
