Re: [DISCUSS] iceberg-rust 0.2.0 release

2024-02-10 Thread Renjie Liu
Thanks! On Sun, Feb 11, 2024 at 10:45 Fokko Driesprong wrote: > Hey Renjie, > > That would be great. I'm happy to do the committer/PMC side of things. > > Let's coordinate on the release tracking issue: > https://github.com/apache/iceberg-rust/issues/180 > > Kind regards, > Fokko > > > > Kind re

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Justin Mclean
HI, > For the Thrift and Hive ones, we have an optional dependency that ships the > content under the vendor/ directory: > https://github.com/apache/iceberg-python/tree/main/vendor These are the > Python Thrift code for talking Thrift to the Hive metastore. Both the Hive > and Thrift NOTICES a

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Justin Mclean
Hi, > However, I don't think the notice for thrift or hive needs to be included. > The license file states that the project uses the thrift definitions, but it > does not include them in the project or dependencies. There are no direct > artifacts from those projects. Since nothing is bundle

Re: [DISCUSS] iceberg-rust 0.2.0 release

2024-02-10 Thread Fokko Driesprong
Hey Renjie, That would be great. I'm happy to do the committer/PMC side of things. Let's coordinate on the release tracking issue: https://github.com/apache/iceberg-rust/issues/180 Kind regards, Fokko Kind regards, Fokko Driesprong Op wo 7 feb 2024 om 03:36 schreef Xuanwo : > Absolutely, we

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Fokko Driesprong
Hi Justin, Dan, Thanks for checking this. For the Avro one, we copied parts of the decompression and binary decoder for the internal PyIceberg implementation (that reads from an Iceberg schema, rather than from an Avro schema). I checked the Avro NOTICE, and there isn't anything relevant. I notic

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Daniel Weeks
I think Fokko will need to weigh in on the avro usage. However, I don't think the notice for thrift or hive needs to be included. The license file states that the project uses the thrift definitions, but it does not include them in the project or dependencies. There are no direct artifacts from t

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Justin Mclean
Hi, Sure, the LICENSE file says it includes code from other ASF projects i.e. Avro, Thrift and Hive. All of these have NOTICE files [1][2][3]. The content from those files (or rather a subset) needs to be included in this releases NOTICE fle. Kind Regards, Justin 1. https://github.com/apache

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Daniel Weeks
Justin, Can you please clarify your comment about the NOTICE file? You said content is missing from the notice file, but this project does not bundle anything external that would qualify to my knowledge. The project dependencies are not included in the distribution. They are installed by the use

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Justin Mclean
Hi, I checked the release and found: - signatures and hashes are fine - LICENSE is fine - NOTICE is missing content from NOTICE of bundled code NOTICE files - All files have ASF headers - No unexpected binary files With a NOTICE file, you need to include the relevant parts in your NOTCE file if

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Sung Yun (BLOOMBERG/ 120 PARK)
Hi everyone, thank you very much for testing out the RC and submitting your votes We would like to unfortunately cancel the current RC and send out a new one that will include the following two critical fixes: - Hive locking - Issue with creating V1 tables with Hive, SQL and Glue catalogs. Tha

Re: [VOTE] Release Apache PyIceberg 0.6.0rc4

2024-02-10 Thread Daniel Weeks
-1 Unfortunately we found that the Hive catalog wasn't properly locking on table updates. I feel that since a major aspect of this release is write support, we shouldn't introduce that feature in an unsafe way. We already have a fix on main, so it shouldn't hold up moving forward with another re