Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > LGTM, just a few comments Thank you for the review, I fixed most of the issues, but have a few question. > On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/h

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > This is a really big/scary change. I am really interested in the > > performance results! :) > > Thanks for all the effort! Some questions below Thank you for the review, i fixed most of them, but have a few questions. > On April 20, 2020

Re: Review Request 72392: HIVE-23103 Oracle statement batching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72392/#review220387 --- standalone-metastore/metastore-server/src/main/java/org/apache/ha

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 21, 2020, 7:53 a.m.) Review request for hive and Peter Vary. R

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Line 172 (original), 225 (patched) > > > > > > P

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72380/ --- (Updated April 21, 2020, 10:22 a.m.) Review request for hive, Denys Kuzmenko an

Re: Review Request 72378: HIVE-23201: Improve logging in locking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220389 --- LGTM, just number of comments ql/src/java/org/apache/hadoop/hive

Re: Review Request 72378: HIVE-23201: Improve logging in locking

> On April 21, 2020, 10:38 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 4427 (patched) > > > > > > I would keep a

Re: Review Request 72379: "get_splits" udf ignores limit constraint when creating splits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72379/ --- (Updated April 21, 2020, 11:17 a.m.) Review request for hive and Sankar Hariapp

[jira] [Created] (HIVE-23263) Add fix order to cbo_rp_limit.q queries + improve readability

Miklos Gergely created HIVE-23263: - Summary: Add fix order to cbo_rp_limit.q queries + improve readability Key: HIVE-23263 URL: https://issues.apache.org/jira/browse/HIVE-23263 Project: Hive

Re: Review Request 72379: "get_splits" udf ignores limit constraint when creating splits

> On April 20, 2020, 2:19 a.m., Sankar Hariappan wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractTestJdbcGenericUDTFGetSplits.java > > Lines 181 (patched) > > > > > > Add test for limit with pr

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 21, 2020, 12:14 p.m.) Review request for hive, Marton Bod and Pe

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

> On April 17, 2020, 7:03 p.m., Peter Vary wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java > > Lines 67 (patched) > > > > > > Why is this needed? These remained here because

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

Re: Review Request 72392: HIVE-23103 Oracle statement batching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72392/ --- (Updated ápr. 21, 2020, 12:41 du) Review request for hive, Denys Kuzmenko and M

Re: Review Request 72392: HIVE-23103 Oracle statement batching

> On ápr. 21, 2020, 7:51 de, Marton Bod wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > > Lines 662 (patched) > > > > > > Once this part executes,

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 21, 2020, 12:51 p.m.) Review request for hive and Peter Vary.

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 699 (patched) > > > > > > openTxns(dbConn, stm

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

[jira] [Created] (HIVE-23264) Make partition_wise_fileformat12.q deterministic with order by clauses

Miklos Gergely created HIVE-23264: - Summary: Make partition_wise_fileformat12.q deterministic with order by clauses Key: HIVE-23264 URL: https://issues.apache.org/jira/browse/HIVE-23264 Project: Hive

Re: Review Request 72392: HIVE-23103 Oracle statement batching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72392/#review220401 --- Ship it! Ship It! - Marton Bod On April 21, 2020, 12:41 p.m.

Review Request 72403: HIVE-19064

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72403/ --- Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-19064 https

[jira] [Created] (HIVE-23265) Duplicate rowsets are returned with Limit and Offset ste

Chiran Ravani created HIVE-23265: Summary: Duplicate rowsets are returned with Limit and Offset ste Key: HIVE-23265 URL: https://issues.apache.org/jira/browse/HIVE-23265 Project: Hive Issue T

[jira] [Created] (HIVE-23266) Remove QueryWrapper from ObjectStore

David Mollitor created HIVE-23266: - Summary: Remove QueryWrapper from ObjectStore Key: HIVE-23266 URL: https://issues.apache.org/jira/browse/HIVE-23266 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-23267) Reduce dependency on groovy

Ashutosh Chauhan created HIVE-23267: --- Summary: Reduce dependency on groovy Key: HIVE-23267 URL: https://issues.apache.org/jira/browse/HIVE-23267 Project: Hive Issue Type: Improvement

Re: Review Request 72403: HIVE-19064

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72403/ --- (Updated April 22, 2020, 5:22 a.m.) Review request for hive and Jesús Camacho R

[jira] [Created] (HIVE-23268) Eliminate beanutils transitive dependency

Ashutosh Chauhan created HIVE-23268: --- Summary: Eliminate beanutils transitive dependency Key: HIVE-23268 URL: https://issues.apache.org/jira/browse/HIVE-23268 Project: Hive Issue Type: Impr