----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72403/ -----------------------------------------------------------
Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-19064 https://issues.apache.org/jira/browse/HIVE-19064 Repository: hive-git Description ------- Add mode to support delimited identifiers enclosed within double quotation Diffs ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e3ddbf197b itests/src/test/resources/testconfiguration.properties c55f8db61a itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java 1c0c62fb13 parser/pom.xml 18e0ad801d parser/src/java/org/apache/hadoop/hive/ql/parse/ANTLRNoCaseStringStream.java PRE-CREATION parser/src/java/org/apache/hadoop/hive/ql/parse/GenericHiveLexer.java PRE-CREATION parser/src/java/org/apache/hadoop/hive/ql/parse/GenericHiveParser.java PRE-CREATION parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 23f74ba05e parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexerParent.g PRE-CREATION parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexerStandard.g PRE-CREATION parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g b03b0989b8 parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParserParent.g PRE-CREATION parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParserStandard.g PRE-CREATION parser/src/java/org/apache/hadoop/hive/ql/parse/Quotation.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AlterViewAddPartitionAnalyzer.java c1d2887ec8 ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java 7820013ab0 ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java 08aeeb2acd ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java 26c7a606bf ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 9bcc472a62 ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 35f7ec674a ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 48c0a4a8ad ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0de3730351 ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 6eb1ca2645 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCastFormat.java 81540ba8c1 ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveUtils.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFCastFormat.java 9afd5af2be ql/src/test/queries/clientnegative/database_create_invalid_name.q 5d6749542b ql/src/test/queries/clientpositive/quotedid_basic_standard.q PRE-CREATION ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q 08df0d803c ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_1.q PRE-CREATION ql/src/test/queries/clientpositive/special_character_in_tabnames_quotes_2.q PRE-CREATION ql/src/test/results/clientnegative/database_create_invalid_name.q.out 4b2cd1e41b ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_1.q.out PRE-CREATION ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_2.q.out PRE-CREATION ql/src/test/results/clientpositive/quotedid_basic_standard.q.out PRE-CREATION ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out b1a808a805 standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java a874121e12 standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 62f5773f9b standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 77d34047a4 standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 3f04abe47a standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java 9d7cfd2a32 standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java 6d82d794ca Diff: https://reviews.apache.org/r/72403/diff/1/ Testing ------- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=quotedid_basic_standard.q,quote2.q,crtseltbl_serdeprops.q -pl itests/qtest -Pitests mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=special_character_in_tabnames_quotes_1.q,special_character_in_tabnames_quotes_2.q,special_character_in_tabnames_1.q,special_character_in_tabnames_2.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa