----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72380/ -----------------------------------------------------------
(Updated April 21, 2020, 10:22 a.m.) Review request for hive, Denys Kuzmenko and Zoltan Chovan. Repository: hive-git Description ------- In the final version the prepDb creates the transactional tables with the init schema (and ignores the others if they exists). The cleanDb resets the database to the starting point. So between the test cases the cleanDb call is enough. If the prepDb is called unneccessary it will just check if the txns table exist and then return, so it will be fast Diffs (updated) ----- contrib/src/test/queries/clientpositive/url_hook.q 512e579fb8 itests/hive-blobstore/pom.xml 09955c55f3 itests/qtest-accumulo/pom.xml a35d2a8a10 itests/qtest-druid/pom.xml cc0cceff68 itests/qtest-kudu/pom.xml f23399fa37 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliAdapter.java fcfc79059a itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java 5b08f8b894 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java b86d736a89 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 38e4bac2cc pom.xml b29c06c69e ql/pom.xml a0e77a1d32 ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java 15fcfc0e35 ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java 1d211857bf ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandlerNoConnectionPool.java ebe4880e3a ql/src/test/org/apache/hadoop/hive/ql/lockmgr/ITestDbTxnManager.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java 73d3b91585 standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java 3e56ad513c standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java bb29410e7d standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java e7910c1c5d standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql 1ace9d3ef0 standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTxns.java 5f3db52c2f standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mysql.java c537d95470 Diff: https://reviews.apache.org/r/72380/diff/2/ Changes: https://reviews.apache.org/r/72380/diff/1-2/ Testing ------- On my machine the 50 tests in TestDbTxnManager2 on postgres runs under 5 minutes. Thanks, Peter Varga
