Question regarding DB Txn Manager

2016-07-29 Thread Rajat Khandelwal
Can somebody please explain or point me to what are db transaction in hive. This is related to https://issues.apache.org/jira/browse/HIVE-14357. I raised this jira after observing a test failures. Would like to gain some understanding regarding what this test failure means, and whether or not the f

Re: Review Request 50548: HIVE-14355 - Schema evolution for ORC in llap is broken for int to string conversion

2016-07-29 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50548/#review144067 --- llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/Llap

Re: Review Request 50575: Estimated size of constant nulls is 0 in some cases

2016-07-29 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50575/#review144068 --- ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java (line

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-29 Thread Marta Kuczora
> On July 28, 2016, 3:03 p.m., Aihua Xu wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java, > > line 95 > > > > > > I see. You are passing OIs even delimiters are missing and also

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-29 Thread Marta Kuczora
> On July 27, 2016, 3:26 p.m., Aihua Xu wrote: > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFStringToMap.java, > > line 34 > > > > > > Please add @Test annotation for unit tests. > > Zoltan Hai

Re: Review Request 50503: HIVE-12954: NPE with str_to_map on null strings

2016-07-29 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/ --- (Updated July 29, 2016, 11:01 a.m.) Review request for hive, Aihua Xu and Sergi

[jira] [Created] (HIVE-14382) Improve the Functionality of Reverse FOR Statement

2016-07-29 Thread Akash Sethi (JIRA)
Akash Sethi created HIVE-14382: -- Summary: Improve the Functionality of Reverse FOR Statement Key: HIVE-14382 URL: https://issues.apache.org/jira/browse/HIVE-14382 Project: Hive Issue Type: Impr

Re: Review Request 50575: Estimated size of constant nulls is 0 in some cases

2016-07-29 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50575/#review144102 --- ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java (line

Re: Review Request 50575: Estimated size of constant nulls is 0 in some cases

2016-07-29 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50575/#review144103 --- Ship it! Ship It! - Jesús Camacho Rodríguez On July 28, 2016

Re: Review Request 50575: Estimated size of constant nulls is 0 in some cases

2016-07-29 Thread Jesús Camacho Rodríguez
> On July 29, 2016, 3:20 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java, line 1461 > > > > > > Because if this column is projecting constant null then numRows = > > cs

Re: Review Request 49882: HIVE-14146: Column comments with "\n" character "corrupts" table metadata

2016-07-29 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49882/#review144109 --- Ship it! Ship It! - Sergio Pena On July 11, 2016, 1:43 p.m.,

Re: Review Request 50575: Estimated size of constant nulls is 0 in some cases

2016-07-29 Thread Ashutosh Chauhan
> On July 29, 2016, 3:20 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java, line 1461 > > > > > > Because if this column is projecting constant null then numRows = > > cs

[jira] [Created] (HIVE-14383) SparkClientImpl should pass principal and keytab to spark-submit instead of calling kinit explicitely

2016-07-29 Thread Mubashir Kazia (JIRA)
Mubashir Kazia created HIVE-14383: - Summary: SparkClientImpl should pass principal and keytab to spark-submit instead of calling kinit explicitely Key: HIVE-14383 URL: https://issues.apache.org/jira/browse/HIVE-14

Re: Review Request 49882: HIVE-14146: Column comments with "\n" character "corrupts" table metadata

2016-07-29 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49882/#review144128 --- Hey Peter, Changes look good. One thing to note is that you may h

[jira] [Created] (HIVE-14384) CBO: Decimal constant folding is failing

2016-07-29 Thread Gopal V (JIRA)
Gopal V created HIVE-14384: -- Summary: CBO: Decimal constant folding is failing Key: HIVE-14384 URL: https://issues.apache.org/jira/browse/HIVE-14384 Project: Hive Issue Type: Bug Component

[jira] [Created] (HIVE-14385) Show create table does not display comments

2016-07-29 Thread Peter Vary (JIRA)
Peter Vary created HIVE-14385: - Summary: Show create table does not display comments Key: HIVE-14385 URL: https://issues.apache.org/jira/browse/HIVE-14385 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-14386) UGI clone shim also needs to clone credentials

2016-07-29 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14386: --- Summary: UGI clone shim also needs to clone credentials Key: HIVE-14386 URL: https://issues.apache.org/jira/browse/HIVE-14386 Project: Hive Issue Type:

[jira] [Created] (HIVE-14387) Add an option to skip the table names for the column headers

2016-07-29 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-14387: -- Summary: Add an option to skip the table names for the column headers Key: HIVE-14387 URL: https://issues.apache.org/jira/browse/HIVE-14387 Project: Hive

[jira] [Created] (HIVE-14388) Add number of rows inserted message after insert command in Beeline

2016-07-29 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-14388: -- Summary: Add number of rows inserted message after insert command in Beeline Key: HIVE-14388 URL: https://issues.apache.org/jira/browse/HIVE-14388 Project

[jira] [Created] (HIVE-14389) Beeline should not output query and prompt to stdout

2016-07-29 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-14389: -- Summary: Beeline should not output query and prompt to stdout Key: HIVE-14389 URL: https://issues.apache.org/jira/browse/HIVE-14389 Project: Hive

Re: Question regarding DB Txn Manager

2016-07-29 Thread Wei Zheng
Hi Rajat, Here’s a good reference for Hive transactions: https://cwiki.apache.org/confluence/display/Hive/Hive+Transactions For the unit test issue that you mentioned, we already noticed that. Thanks for pointing it out! Thanks, Wei On 7/29/16, 01:30, "Rajat Khandelwal" wrote: Can someb

Re: Review Request 50359: HIVE-14270: Write temporary data to HDFS when doing inserts on tables located on S3

2016-07-29 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50359/#review144220 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 18

Re: Review Request 50359: HIVE-14270: Write temporary data to HDFS when doing inserts on tables located on S3

2016-07-29 Thread Sergio Pena
> On July 29, 2016, 11:33 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, lines 1840-1841 > > > > > > I don't follow this. Comment doesn't seem to match code. > > Fil