-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50548/#review144067
-----------------------------------------------------------




llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java
 (line 119)
<https://reviews.apache.org/r/50548/#comment210052>

    for me it looks like that it might be possible to merge the two 'llap can 
be used' conditions
    
    * this one useLlapIo
    * and the one inside init()
    
    not sure...maybe worth a look


- Zoltan Haindrich


On July 29, 2016, 6:58 a.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50548/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 6:58 a.m.)
> 
> 
> Review request for hive and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-14355
>     https://issues.apache.org/jira/browse/HIVE-14355
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java
>  9d16889 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java
>  abd4533 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java
>  7db519c 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java
>  3dfab63 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ReadPipeline.java 
> 21b1772 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
>  93c40e4 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0a2c3fa 
> 
> Diff: https://reviews.apache.org/r/50548/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>

Reply via email to