----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/ -----------------------------------------------------------
(Updated July 29, 2016, 11:01 a.m.) Review request for hive, Aihua Xu and Sergio Pena. Changes ------- Fixed the patch according to the review findings. Bugs: HIVE-12954 https://issues.apache.org/jira/browse/HIVE-12954 Repository: hive-git Description ------- HIVE-12954: NPE with str_to_map on null strings Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java ed60fbf ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFStringToMap.java PRE-CREATION Diff: https://reviews.apache.org/r/50503/diff/ Testing ------- Added new unit test for GenericUDFStringToMap, please see the patch for details. Also did manual testing. Thanks, Marta Kuczora