Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-13 Thread Malcolm Taylor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/ --- (Updated July 13, 2017, 8 a.m.) Review request for hive. Changes --- reb

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-12 Thread Malcolm Taylor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/ --- (Updated July 12, 2017, 7:29 a.m.) Review request for hive. Bugs: HIVE-16989

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-12 Thread Malcolm Taylor
> On July 11, 2017, 6:04 p.m., Prasanth_J wrote: > > .reviewboardrc > > Line 1 (original), 1 (patched) > > > > > > Is this triggerring an alert? Better to leave the license as such else > > Apache Rat will cause failu

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-12 Thread Malcolm Taylor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/ --- (Updated July 12, 2017, 7:27 a.m.) Review request for hive. Changes ---

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-11 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/#review180227 --- .reviewboardrc Line 1 (original), 1 (patched)

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-11 Thread Malcolm Taylor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/ --- (Updated July 11, 2017, 10:05 a.m.) Review request for hive. Bugs: HIVE-16989

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-11 Thread Malcolm Taylor
> On July 11, 2017, 7:27 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java > > Line 63 (original) > > > > > > That's probably a bug? Thanks for the suggestion Gopal V. Looking a

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-11 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/#review180168 --- ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java L

Re: Review Request 60728: HIVE-16989: fix some alerts found by lgtm.com

2017-07-11 Thread Malcolm Taylor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/ --- (Updated July 11, 2017, 7:13 a.m.) Review request for hive. Summary (updated)