----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/#review180168 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java Line 63 (original) <https://reviews.apache.org/r/60728/#comment255206> That's probably a bug? - Gopal V On July 11, 2017, 7:13 a.m., Malcolm Taylor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60728/ > ----------------------------------------------------------- > > (Updated July 11, 2017, 7:13 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-16989 > fix some alerts found by lgtm.com > > fix TextKeyWrapper.equals and add tests > > > add .reviewboardrc > > > Diffs > ----- > > .reviewboardrc 49231678a72bc37efe052bf2d41006f3b595f7ab > beeline/src/java/org/apache/hive/beeline/BeeLine.java > 33a65d49656c77cf0736df0c53bd32c13fea6173 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java > 15968fa95e40a17d575c546c4880440b7bd93fd0 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > d6d83e03ac583a5f0e6e9144595e3999786d1648 > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 970038dd6126732840f1a8619fcf7efaa742b956 > ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java > 5154a5fbe99c37bd2279f991a5e286a9c04918a4 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java > 9b1af1bd38e694c7f670aee0508cfb832fd109b7 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java > a7fad7177e39ef9112f08da0e7e6cc714ef96b8a > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java > 2d5e3b168b7cb2c3cf323533790af4bd87a333b8 > ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java > 5d7ddc880a566e63237e4b76fd1d6e614d502974 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java > 2b5e6dd31d2b1c58d55a6e2bb1eb615748bc83e0 > ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60728/diff/1/ > > > Testing > ------- > > Ran tests. Some tests failed, but also appear to fail on master. > Added tests for equals() methods in KeyWrapper classes, which fail on master > but pass with this patch. > > > Thanks, > > Malcolm Taylor > >
