> On July 11, 2017, 6:04 p.m., Prasanth_J wrote: > > .reviewboardrc > > Line 1 (original), 1 (patched) > > <https://reviews.apache.org/r/60728/diff/2/?file=1774039#file1774039line1> > > > > Is this triggerring an alert? Better to leave the license as such else > > Apache Rat will cause failures (if not added to ignore list).
Thanks Prasanth_J. I have rebased, and dropped the change to .reviewboardrc in the latest patch. The file didn't trigger any alerts and it was my mistake to include that change in the earlier patch. - Malcolm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60728/#review180227 ----------------------------------------------------------- On July 12, 2017, 7:27 a.m., Malcolm Taylor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60728/ > ----------------------------------------------------------- > > (Updated July 12, 2017, 7:27 a.m.) > > > Review request for hive. > > > Bugs: HIVE-16989 > https://issues.apache.org/jira/browse/HIVE-16989 > > > Repository: hive-git > > > Description > ------- > > HIVE-16989 > fix some alerts found by lgtm.com > > fix TextKeyWrapper.equals and add tests > > > add .reviewboardrc > > > Diffs > ----- > > .reviewboardrc 4923167 > beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d4 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java > 15968fa > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > d6d83e0 > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 970038d > ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5f > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java > 9b1af1b > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java > a7fad71 > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java > 2d5e3b1 > ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc8 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java > 2b5e6dd > ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60728/diff/2/ > > > Testing > ------- > > Ran tests. Some tests failed, but also appear to fail on master. > Added tests for equals() methods in KeyWrapper classes, which fail on master > but pass with this patch. > > > File Attachments > ---------------- > > HIVE-16989.4.patch > > https://reviews.apache.org/media/uploaded/files/2017/07/12/eebaa7c1-a348-4e8f-a880-4e69e20bdee0__HIVE-16989.4.patch > > > Thanks, > > Malcolm Taylor > >
