Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/#review174049 --- Ship it! Ship It! - Prasanth_J On May 5, 2017, 10:30 a.m., J

Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-05 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/ --- (Updated May 5, 2017, 10:30 a.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/#review174008 --- llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordRea

Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-04 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/ --- (Updated May 5, 2017, 2:49 a.m.) Review request for hive, Gunther Hagleitner, P

Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-04 Thread Jason Dere
> On May 3, 2017, 5:34 a.m., Prasanth_J wrote: > > llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java > > Lines 154 (patched) > > > > > > IIRC, there are utilities already to do this in ObjectI

Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-03 Thread j . prasanth . j
> On May 3, 2017, 5:34 a.m., Prasanth_J wrote: > > llap-common/src/java/org/apache/hadoop/hive/llap/TypeDesc.java > > Lines 154 (patched) > > > > > > This also looks repetitive. TypeInfoUtils already has something li

Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-03 Thread Jason Dere
> On May 3, 2017, 5:34 a.m., Prasanth_J wrote: > > llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java > > Lines 154 (patched) > > > > > > IIRC, there are utilities already to do this in ObjectI

Re: Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-02 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/#review173697 --- llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordRea

Review Request 58934: HIVE-16568: Support complex types in external LLAP InputFormat

2017-05-02 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/ --- Review request for hive, Gunther Hagleitner, Prasanth_J, and Siddharth Seth. Bu