----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/#review174008 -----------------------------------------------------------
llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java Lines 168 (patched) <https://reviews.apache.org/r/58934/#comment247101> if listSize <0 set the convertedVal to null? llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java Lines 181 (patched) <https://reviews.apache.org/r/58934/#comment247100> if mapSize is <0 then getMap() will return null. Potential NPE here. - Prasanth_J On May 5, 2017, 2:49 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58934/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 2:49 a.m.) > > > Review request for hive, Gunther Hagleitner, Prasanth_J, and Siddharth Seth. > > > Bugs: HIVE-16568 > https://issues.apache.org/jira/browse/HIVE-16568 > > > Repository: hive-git > > > Description > ------- > > - Support list/map/struct types in the LLAPRowInputFormat Schema/TypeDesc > - Support list/map/struct types in the LLAPRowInputFormat Row. Changes in the > Row getters/setters needed (no longer using Writable). > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/llap/ext/TestLlapInputSplit.java > 654e92b > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlap.java > de47412 > llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java > ee92f3e > llap-common/src/java/org/apache/hadoop/hive/llap/FieldDesc.java 9621978 > llap-common/src/java/org/apache/hadoop/hive/llap/Row.java a84fadc > llap-common/src/java/org/apache/hadoop/hive/llap/TypeDesc.java dda5928 > llap-common/src/test/org/apache/hadoop/hive/llap/TestRow.java d4e68f4 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 9ddbd7e > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > b003eb8 > > > Diff: https://reviews.apache.org/r/58934/diff/2/ > > > Testing > ------- > > Added test to TestJdbcWithMiniLlap > > > Thanks, > > Jason Dere > >
