----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58934/#review173697 -----------------------------------------------------------
llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java Lines 154 (patched) <https://reviews.apache.org/r/58934/#comment246743> IIRC, there are utilities already to do this in ObjectInspectorUtils.. copyToXXX() methods.. can that be reused? llap-common/src/java/org/apache/hadoop/hive/llap/TypeDesc.java Lines 154 (patched) <https://reviews.apache.org/r/58934/#comment246744> This also looks repetitive. TypeInfoUtils already has something like this I guess. We need to make sure TypeInfo parser can parse the string generated by this method. It's easier to reuse TypeInfoUtils or have a TypeDesc converted to TypeInfo. My point there is duplicacy in TypeInfo TypeDesc TypeDescriptor (ORC has this) Wondering if TypeInfo or TypeDescriptor from ORC can be reused here. Thoughts? - Prasanth_J On May 2, 2017, 9:52 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58934/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 9:52 p.m.) > > > Review request for hive, Gunther Hagleitner, Prasanth_J, and Siddharth Seth. > > > Bugs: HIVE-16568 > https://issues.apache.org/jira/browse/HIVE-16568 > > > Repository: hive-git > > > Description > ------- > > - Support list/map/struct types in the LLAPRowInputFormat Schema/TypeDesc > - Support list/map/struct types in the LLAPRowInputFormat Row. Changes in the > Row getters/setters needed (no longer using Writable). > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlap.java > de47412 > llap-client/src/java/org/apache/hadoop/hive/llap/LlapRowRecordReader.java > ee92f3e > llap-common/src/java/org/apache/hadoop/hive/llap/Row.java a84fadc > llap-common/src/java/org/apache/hadoop/hive/llap/TypeDesc.java dda5928 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 9ddbd7e > > > Diff: https://reviews.apache.org/r/58934/diff/1/ > > > Testing > ------- > > Added test to TestJdbcWithMiniLlap > > > Thanks, > > Jason Dere > >
