Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-12 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review64931 --- Ship it! Ship It! - Thejas Nair On Dec. 12, 2014, 7:32 a.m., Nav

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
> On Dec. 9, 2014, 8:31 p.m., Mohit Sabharwal wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 556 > > > > > > nit: while we're here, this code will be cleaner if we replace the many > > continues wi

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/ --- (Updated Dec. 12, 2014, 7:32 a.m.) Review request for hive. Bugs: HIVE-8357

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
> On Dec. 9, 2014, 8:41 p.m., Mohit Sabharwal wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java, line > > 236 > > > > > > Looks like FileUtils.isLocalFile is a 'best effort' check based

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/ --- (Updated Dec. 12, 2014, 7:31 a.m.) Review request for hive. Bugs: HIVE-8357

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-11 Thread Navis Ryu
> On Oct. 21, 2014, 5:04 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java, line > > 236 > > > > > > if the user has specified using syntax that this is a local file pa

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-09 Thread Thejas Nair
> On Oct. 21, 2014, 5:04 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java, line > > 236 > > > > > > if the user has specified using syntax that this is a local file pa

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-09 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review64432 --- ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.ja

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-09 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review64424 --- Just passing by... ql/src/java/org/apache/hadoop/hive/ql/Driver.ja

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-12-08 Thread Navis Ryu
> On Oct. 21, 2014, 5:04 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java, line > > 236 > > > > > > if the user has specified using syntax that this is a local file pa

Re: Review Request 26966: Path type entities should use qualified path rather than string

2014-10-21 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/#review57607 --- ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.ja

Review Request 26966: Path type entities should use qualified path rather than string

2014-10-20 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26966/ --- Review request for hive. Bugs: HIVE-8357 https://issues.apache.org/jira/bro