Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-10 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/#review52883 --- This looks great! I think we are almost ready to commit. Can you add

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-10 Thread Lars Francke
> On Sept. 9, 2014, 8:49 a.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java, line 151 > > > > > > I don't quite get this comment. Looking at the two CSVReader > > constructors the

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-10 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/#review52832 --- serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-09 Thread cheng xu
> On Sept. 9, 2014, 8:49 a.m., Lars Francke wrote: > > Looks good apart from minor comments. > > > > Maybe add a test for the Serialization part? > > https://issues.apache.org/jira/browse/HIVE-5976 integration might be nice: > > "STORED AS CSV". Unfortunately there's no documentation yet so I'm

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-09 Thread cheng xu
> On Sept. 9, 2014, 3:07 p.m., Brock Noland wrote: > > serde/pom.xml, line 73 > > > > > > These should only be indented by two spaces, not four. Have you tried > > submitting an MR job on a cluster with this patch? The

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-09 Thread cheng xu
> On Sept. 9, 2014, 8:49 a.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java, line 151 > > > > > > I don't quite get this comment. Looking at the two CSVReader > > constructors the

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-09 Thread Lefty Leverenz
> On Sept. 9, 2014, 8:49 a.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java, line 31 > > > > > > This comment doesn't add value so I suggest removing it. Or you could expand the co

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-09 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/#review52723 --- Great work! serde/pom.xml

Re: Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-09 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/#review52688 --- Looks good apart from minor comments. Maybe add a test for the Seri

Review Request 25468: HIVE-7777: add CSVSerde support

2014-09-08 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/ --- Review request for hive. Bugs: HIVE- https://issues.apache.org/jira/bro