Re: Review Request: add exception handling to hive's record reader

2011-06-01 Thread Yongqiang He
> On 2011-06-01 06:48:14, Ning Zhang wrote: > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java, > > line 57 > > > > > > Do you need to throw exception when all handler return false?

Re: Review Request: add exception handling to hive's record reader

2011-05-31 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/#review741 --- trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHa

Re: Review Request: add exception handling to hive's record reader

2011-05-31 Thread Yongqiang He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/ --- (Updated 2011-06-01 00:38:42.863958) Review request for hive. Changes ---

Re: Review Request: add exception handling to hive's record reader

2011-05-31 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/#review740 --- trunk/conf/hive-default.xml

Re: Review Request: add exception handling to hive's record reader

2011-05-31 Thread Yongqiang He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/ --- (Updated 2011-05-31 20:31:23.581581) Review request for hive. Changes ---

Review Request: add exception handling to hive's record reader

2011-05-31 Thread Yongqiang He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/ --- Review request for hive. Summary --- add exception handling to hive's record