----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/#review740 -----------------------------------------------------------
trunk/conf/hive-default.xml <https://reviews.apache.org/r/812/#comment1493> comment should be more specific: class names of the exception handlers. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java <https://reviews.apache.org/r/812/#comment1494> rename the variable to indicate it is a chain rather than just 1 handler. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java <https://reviews.apache.org/r/812/#comment1497> this function throws IOException but the original code throws RuntimeException. Should check if this is OK. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java <https://reviews.apache.org/r/812/#comment1496> same as below trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java <https://reviews.apache.org/r/812/#comment1495> check if the function return false and throw exception trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java <https://reviews.apache.org/r/812/#comment1498> indentation trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java <https://reviews.apache.org/r/812/#comment1499> comment on what the innerReader is when there is an exception in the first call of getRecordReader(). trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java <https://reviews.apache.org/r/812/#comment1500> also need to throw exception when all handlers return false. Should try to refactor the code - Ning On 2011-05-31 20:31:23, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/812/ > ----------------------------------------------------------- > > (Updated 2011-05-31 20:31:23) > > > Review request for hive. > > > Summary > ------- > > add exception handling to hive's record reader > > > This addresses bug HIVE-2154. > https://issues.apache.org/jira/browse/HIVE-2154 > > > Diffs > ----- > > trunk/conf/hive-default.xml 1127229 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java > 1101261 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1101261 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java > 1101261 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java > 1101261 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java > 1101261 > trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > 1101261 > trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java > 1101261 > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java > PRE-CREATION > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java > PRE-CREATION > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/812/diff > > > Testing > ------- > > > Thanks, > > Yongqiang > >
