----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/#review741 -----------------------------------------------------------
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java <https://reviews.apache.org/r/812/#comment1516> This function is not intuitive. Maybe you need more comments about the why it is designed this way. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java <https://reviews.apache.org/r/812/#comment1514> Do you need to throw exception when all handler return false? trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java <https://reviews.apache.org/r/812/#comment1515> same as above - Ning On 2011-06-01 00:38:42, Yongqiang He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/812/ > ----------------------------------------------------------- > > (Updated 2011-06-01 00:38:42) > > > Review request for hive. > > > Summary > ------- > > add exception handling to hive's record reader > > > This addresses bug HIVE-2154. > https://issues.apache.org/jira/browse/HIVE-2154 > > > Diffs > ----- > > trunk/conf/hive-default.xml 1129953 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java > 1129953 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1129953 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java > 1129953 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java > 1129953 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java > 1129953 > trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > 1129953 > trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java > 1129953 > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java > PRE-CREATION > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java > PRE-CREATION > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java > PRE-CREATION > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/812/diff > > > Testing > ------- > > > Thanks, > > Yongqiang > >
