Re: Review Request 68281: HIVE-20354

2018-08-10 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/ --- (Updated Aug. 10, 2018, 8:59 p.m.) Review request for hive, Eugene Koifman and

Re: Review Request 68281: HIVE-20354

2018-08-09 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/ --- (Updated Aug. 10, 2018, 6:48 a.m.) Review request for hive, Eugene Koifman and

Re: Review Request 68281: HIVE-20354

2018-08-09 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/#review207051 --- ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticA

Re: Review Request 68281: HIVE-20354

2018-08-09 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/ --- (Updated Aug. 9, 2018, 7:19 p.m.) Review request for hive, Eugene Koifman and J

Re: Review Request 68281: HIVE-20354

2018-08-09 Thread Deepak Jaiswal
> On Aug. 9, 2018, 6:33 p.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java > > Lines 1000 (patched) > > > > > > why not save it directly into setHintList()? It ha

Re: Review Request 68281: HIVE-20354

2018-08-09 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/#review207047 --- ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticA

Re: Review Request 68281: HIVE-20354

2018-08-09 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/#review207043 --- ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticA