----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/#review207043 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java Lines 1000 (patched) <https://reviews.apache.org/r/68281/#comment290214> Modifying parse tree directly is not a good idea - it messes up internal ANTLR strucutres and may cause issues downstream. You should inject the hint into 'rewrittenQueryStr' so that a complete new statement is parsed - that is the model for all other parts of Merge reparsing. ql/src/test/queries/clientpositive/semijoin_hint.q Lines 116 (patched) <https://reviews.apache.org/r/68281/#comment290215> it may be useful to one statment with hint and another w/o hint - to see clearly the difference in the plan. - Eugene Koifman On Aug. 9, 2018, 10:44 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68281/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2018, 10:44 a.m.) > > > Review request for hive, Eugene Koifman and Jason Dere. > > > Bugs: HIVE-20354 > https://issues.apache.org/jira/browse/HIVE-20354 > > > Repository: hive-git > > > Description > ------- > > Semijoin hints dont work with merge statements. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g f4d12ae564 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 463880587e > > ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java > 8df290435d > ql/src/test/queries/clientpositive/semijoin_hint.q de176affd3 > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out 679916de07 > > > Diff: https://reviews.apache.org/r/68281/diff/1/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
