> On Aug. 9, 2018, 6:33 p.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java > > Lines 1000 (patched) > > <https://reviews.apache.org/r/68281/diff/1/?file=2070795#file2070795line1000> > > > > why not save it directly into setHintList()?
It has to be first processed before it can be set. Anyway I am going to abandon this approach in favor of what Eugene suggested. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68281/#review207047 ----------------------------------------------------------- On Aug. 9, 2018, 5:44 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68281/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2018, 5:44 p.m.) > > > Review request for hive, Eugene Koifman and Jason Dere. > > > Bugs: HIVE-20354 > https://issues.apache.org/jira/browse/HIVE-20354 > > > Repository: hive-git > > > Description > ------- > > Semijoin hints dont work with merge statements. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g f4d12ae564 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 463880587e > > ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java > 8df290435d > ql/src/test/queries/clientpositive/semijoin_hint.q de176affd3 > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out 679916de07 > > > Diff: https://reviews.apache.org/r/68281/diff/1/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
