Re: Review Request 56070: HIVE-15748

2017-01-31 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/ --- (Updated Jan. 31, 2017, 11:30 p.m.) Review request for hive and Jason Dere. C

Re: Review Request 56070: HIVE-15748

2017-01-31 Thread Deepak Jaiswal
> On Jan. 31, 2017, 4:46 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java, > > line 808 > > > > > > Can the parent be the result of a join in this case? If so there

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/#review163620 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoi

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/ --- (Updated Jan. 31, 2017, 12:44 a.m.) Review request for hive and Jason Dere. C

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
> On Jan. 30, 2017, 10:27 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java, > > line 33 > > > > > > importing * is not normally considered to be good form, try to av

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/#review163574 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoi