----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/#review163574 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java (line 33) <https://reviews.apache.org/r/56070/#comment235027> importing * is not normally considered to be good form, try to avoid doing that if possible. ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java (line 772) <https://reviews.apache.org/r/56070/#comment235028> Not sure if the parent of the ReduceSink parent is necesaarily always a SELECT operator. Might want to try some tests with select * or selecting all columns to verify, since the SelectOperator might be omitted if there is no need for projection. ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java (line 791) <https://reviews.apache.org/r/56070/#comment235033> Maybe use OperatorUtils.findOperatorsUpstream() ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java (line 560) <https://reviews.apache.org/r/56070/#comment235035> Clean this up - Jason Dere On Jan. 30, 2017, 8:30 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56070/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 8:30 a.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-15748 > https://issues.apache.org/jira/browse/HIVE-15748 > > > Repository: hive-git > > > Description > ------- > > Remove cycles due to Mapjoin and semijoin combo > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > beed6b8 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 6141391 > ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q 13797c0 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > e89526e > > Diff: https://reviews.apache.org/r/56070/diff/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
