> On Jan. 31, 2017, 4:46 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java, > > line 808 > > <https://reviews.apache.org/r/56070/diff/2/?file=1619635#file1619635line808> > > > > Can the parent be the result of a join in this case? If so there may be > > more than 1 TableScan Operator coming back from this.
Its a valid point. Will fix this in next patch. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/#review163620 ----------------------------------------------------------- On Jan. 31, 2017, 12:44 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56070/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 12:44 a.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-15748 > https://issues.apache.org/jira/browse/HIVE-15748 > > > Repository: hive-git > > > Description > ------- > > Remove cycles due to Mapjoin and semijoin combo > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > beed6b8 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java 6141391 > ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q 13797c0 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > e89526e > > Diff: https://reviews.apache.org/r/56070/diff/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
