Re: Review Request 51468: HIVE-14532 - enable qtests from ide - eclipse

2016-09-09 Thread Peter Vary
> On Aug. 28, 2016, 3:07 p.m., Peter Vary wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java, > > lines 80-84 > > > > > > It is mostly just a question, which appeared to me

Re: Review Request 51468: HIVE-14532 - enable qtests from ide - eclipse

2016-09-07 Thread Zoltan Haindrich
> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Haindrich wrote: > I don't think so...this property

Re: Review Request 51468: HIVE-14532 - enable qtests from ide - eclipse

2016-09-07 Thread Zoltan Haindrich
> On Aug. 28, 2016, 3:07 p.m., Peter Vary wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java, > > lines 80-84 > > > > > > It is mostly just a question, which appeared to me

Re: Review Request 51468: HIVE-14532 - enable qtests from ide - eclipse

2016-09-07 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/ --- (Updated Sept. 7, 2016, 8:39 p.m.) Review request for hive, Balint Molnar, Left

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-29 Thread Gabor Szadovszky
> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Haindrich wrote: > I don't think so...this property

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-28 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147100 --- Fix it, then Ship it! Just some random thoughts in the morning

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-28 Thread Zoltan Haindrich
> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Haindrich wrote: > I don't think so...this property

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-27 Thread Gabor Szadovszky
> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Haindrich wrote: > I don't think so...this property

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-27 Thread Zoltan Haindrich
> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java, > > line 61 > > > > > > I cannot see the purpose of this change. Is it still r

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-27 Thread Zoltan Haindrich
> On Aug. 26, 2016, 11:50 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/EnforceReadOnlyTables.java, > > line 40 > > > > > > If the test.src.tables property is not set, and the AbstractCliCon

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-27 Thread Zoltan Haindrich
> On Aug. 26, 2016, 10:40 p.m., Prasanth_J wrote: > > pom.xml, lines 1292-1297 > > > > > > Any reason to skip shading for IDE? Is it purely performance? If so how > > much will that be? IMHO it's better to debug wi

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-26 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147046 --- An Eclipse developer at last. :) Thanks a lot for the patch. I hav

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-26 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147043 --- I see, the Eclipse test runs cause more headache than with Intelli

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147038 --- pom.xml (lines 1292 - 1297)

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-26 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147039 --- Other changes looks good to me. - Prasanth_J On Aug. 26, 2016,

Re: Review Request 51468: HIVE-14532 Enable qtests from IDE

2016-08-26 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147035 --- pom.xml (lines 1292 - 1297)