> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > <https://reviews.apache.org/r/51468/diff/1/?file=1487193#file1487193line195> > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Haindrich wrote: > I don't think so...this property will affect everything where its > used...when the ide profile is inactive it will work as before. > > Gabor Szadovszky wrote: > Then, the comment "this will enable by default the shade plugin" in the > root pom is a bit misleading to me. > > Zoltan Haindrich wrote: > disabling the shade plugin was not easy...contolling its execution phase > seemed the most straight forward way to control its skip... > it's not good to have a comment which is misleading... > > * do you have any suggestion? > * sould i remove the comment? I think the property name is self > explaining about what it does - and that way you may look up its uses and > figure out its function from the actual configuration.. > > Gabor Szadovszky wrote: > For me the comment means that the shade plugin will run for all the > submodules which is not true. I would say something like "Used for > enabling/disabling the shade plugin where it is relevant. Enabled by > default." What do you think?
i've changed the note...makes more sense ;) - Zoltan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147046 ----------------------------------------------------------- On Sept. 7, 2016, 8:39 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51468/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 8:39 p.m.) > > > Review request for hive, Balint Molnar, Lefty Leverenz, and Prasanth_J. > > > Bugs: HIVE-14532 > https://issues.apache.org/jira/browse/HIVE-14532 > > > Repository: hive-git > > > Description > ------- > > how to execute qtests for ide wikipage draft: > v1: http://hastebin.com/paxicutive.vhdl > > the patch itself contains: > > * some automatic property settings to configure qtest related things to be > able to execute > * maven profile to avoid shading plugin invocation during IDE project > generation - to void classpath/compile errors i've encountered > * some test.src.tables related changes - defaulting is now done at a > different place > * eclipse is ok for me > > patch#2 here is patch#3 in the jira > > > Diffs > ----- > > itests/hive-jmh/pom.xml f1417fd7e8b70a7a3dd255c25d3909013f02df67 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java > efbd4657f22e856b9c9ba5f74472ad5fd9f9a5b5 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > 69c4974105c6b47cc8e8051cd980274c9c381775 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 4d4a929c159c61f9f4af3238d4b7baff146d346e > jdbc/pom.xml b29739b3f8577c6e363b5c8ee39b63e53a17c907 > pom.xml 4c41200ffc8e2c9a1d207f8676f252b94e80e4fd > ql/pom.xml 02ddb805a228ed23694c8a81953dd2400d7308c6 > > Diff: https://reviews.apache.org/r/51468/diff/ > > > Testing > ------- > > I've tested the draft using eclipse: > 3.0 -> 3.1 -> TestCliDriver(combine2,alter_concatenate_indexed_table) > 3.0 -> 3.2 -> TestCliDriver(combine2) > > idea: > althrough I was able to create a few working setups...I think it will need > more work > > > Thanks, > > Zoltan Haindrich > >
