> On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > pom.xml, line 195 > > <https://reviews.apache.org/r/51468/diff/1/?file=1487193#file1487193line195> > > > > Wouldn't it infect the other modules (production) as well? > > Zoltan Haindrich wrote: > I don't think so...this property will affect everything where its > used...when the ide profile is inactive it will work as before.
Then, the comment "this will enable by default the shade plugin" in the root pom is a bit misleading to me. > On Aug. 27, 2016, 12:25 a.m., Gabor Szadovszky wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java, > > line 61 > > <https://reviews.apache.org/r/51468/diff/1/?file=1487190#file1487190line61> > > > > I cannot see the purpose of this change. Is it still related to the > > test execution in the IDE? > > (Seems there are some implementations depending on the value "". E.g. > > QTestUtil.) > > Could you please add some explanation about it? > > Zoltan Haindrich wrote: > I've had failures running tests with ""...instead of fixing the > automatism; i've just made it explicit - and this is also one step toward > removing unneeded things. > > I think being more explicit about where the hive conf is better than > relying on some null/empty defaulting inside QTestUtil I agree. Do we have a jira to keep tracking the ongoing changes (to not to forget the removing of the unneeded things...)? - Gabor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147046 ----------------------------------------------------------- On Aug. 26, 2016, 10:13 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51468/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 10:13 p.m.) > > > Review request for hive, Balint Molnar, Lefty Leverenz, and Prasanth_J. > > > Bugs: HIVE-14532 > https://issues.apache.org/jira/browse/HIVE-14532 > > > Repository: hive-git > > > Description > ------- > > how to execute qtests for ide wikipage draft: > http://hastebin.com/paxicutive.vhdl > > the patch itself contains: > > * some automatic property settings to configure qtest related things to be > able to execute > * maven profile to avoid shading plugin invocation during IDE project > generation > * some test.src.tables related changes > > > Diffs > ----- > > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java > efbd4657f22e856b9c9ba5f74472ad5fd9f9a5b5 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > 319a205225c67f123ba35a2811ee117650d46dc3 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 4d4a929c159c61f9f4af3238d4b7baff146d346e > jdbc/pom.xml b29739b3f8577c6e363b5c8ee39b63e53a17c907 > pom.xml 9ed1c19f3e312ee1f1d9932ee2ba228589a7cb49 > ql/pom.xml 02ddb805a228ed23694c8a81953dd2400d7308c6 > ql/src/java/org/apache/hadoop/hive/ql/hooks/EnforceReadOnlyTables.java > 4569ed5e41f2f4db8f3d539d7cfb693c442ba910 > > Diff: https://reviews.apache.org/r/51468/diff/ > > > Testing > ------- > > I've tested the draft using eclipse: > 3.0 -> 3.1 -> TestCliDriver(combine2,alter_concatenate_indexed_table) > 3.0 -> 3.2 -> TestCliDriver(combine2) > > I think this should work with idea too...but someone should possibly check it > ;) > > > Thanks, > > Zoltan Haindrich > >
