Re: Proposal to switch to pull requests

2014-03-10 Thread Thejas Nair
Agree with Carl about git merge commits, they make the changes hard to follow. But it should be OK, if there is no way to disable it in the main git repo, it is a small set of active committers, we can make a policy and expect people to follow it. But we should certainly disable 'git push -f' (and

Re: Proposal to switch to pull requests

2014-03-09 Thread Carl Steinbach
I'm +1 on switching to git, but only if we can find a way to disable merge commits to trunk and feature branches. I'm -1 on switching to Github since, as far as I know, it only supports merge based workflows. On Sun, Mar 9, 2014 at 12:25 PM, Edward Capriolo wrote: > I do not think we want Pull R

Re: Proposal to switch to pull requests

2014-03-09 Thread Edward Capriolo
I do not think we want Pull Requests coming at us. Better way is let someone open a git branch for the changes, then we review and merge the branch. On Sat, Mar 8, 2014 at 4:25 PM, Brock Noland wrote: > In my read of the Apache git - github integration blog post we cannot use > pull requests as

Re: Proposal to switch to pull requests

2014-03-08 Thread Brock Noland
In my read of the Apache git - github integration blog post we cannot use pull requests as patches. Just that we'll be notified of them and could perhaps use them as code review. One additional item I think we should investigate is disabling merge commits on trunk and feature branches. On Mar 7, 2

Re: Proposal to switch to pull requests

2014-03-07 Thread Edward Capriolo
We need to keep patches in Jira I feel. We have gotten better on the documentation front but having a patch in the jira is critical I feel. We must at least have a perma link to the changes. On Fri, Mar 7, 2014 at 8:40 PM, Sergey Shelukhin wrote: > +1 to git! > > > On Fri, Mar 7, 2014 at 12:46 P

Re: Proposal to switch to pull requests

2014-03-07 Thread Sergey Shelukhin
+1 to git! On Fri, Mar 7, 2014 at 12:46 PM, Xuefu Zhang wrote: > Switching to git from svn seems to be a proposal slightly different from > that of switching to pull request from the head of the thread. Personally > I'm +1 to git, but I think patches are very portable and widely adopted in > Ha

Re: Proposal to switch to pull requests

2014-03-07 Thread Xuefu Zhang
Switching to git from svn seems to be a proposal slightly different from that of switching to pull request from the head of the thread. Personally I'm +1 to git, but I think patches are very portable and widely adopted in Hadoop ecosystem and we should keep the practice. Thus, +1 to that also. --X

Re: Proposal to switch to pull requests

2014-03-07 Thread Gunther Hagleitner
Once Prasad's loop finishes I'd like to add my +1 too. On Fri, Mar 7, 2014 at 11:44 AM, Vaibhav Gumashta wrote: > +1 for moving to git! > > Thanks, > --Vaibhav > > > On Fri, Mar 7, 2014 at 9:46 AM, Prasad Mujumdar >wrote: > > > while (true) { > >+1 > > } > > > > +1 // another, just

Re: Proposal to switch to pull requests

2014-03-07 Thread Vaibhav Gumashta
+1 for moving to git! Thanks, --Vaibhav On Fri, Mar 7, 2014 at 9:46 AM, Prasad Mujumdar wrote: > while (true) { >+1 > } > > +1 // another, just in case ;) > > thanks > Prasad > > > > On Fri, Mar 7, 2014 at 6:47 AM, kulkarni.swar...@gmail.com < > kulkarni.swar...@gmail.com> wrote: > >

Re: Proposal to switch to pull requests

2014-03-07 Thread Prasad Mujumdar
while (true) { +1 } +1 // another, just in case ;) thanks Prasad On Fri, Mar 7, 2014 at 6:47 AM, kulkarni.swar...@gmail.com < kulkarni.swar...@gmail.com> wrote: > +1 > > > On Fri, Mar 7, 2014 at 1:05 AM, Thejas Nair > wrote: > > > Should we start with moving our primary source code

Re: Proposal to switch to pull requests

2014-03-07 Thread kulkarni.swar...@gmail.com
+1 On Fri, Mar 7, 2014 at 1:05 AM, Thejas Nair wrote: > Should we start with moving our primary source code repository from > svn to git ? I feel git is more powerful and easy to use (once you go > past the learning curve!). > > > On Wed, Mar 5, 2014 at 7:39 AM, Brock Noland wrote: > > Persona

Re: Proposal to switch to pull requests

2014-03-06 Thread Thejas Nair
Should we start with moving our primary source code repository from svn to git ? I feel git is more powerful and easy to use (once you go past the learning curve!). On Wed, Mar 5, 2014 at 7:39 AM, Brock Noland wrote: > Personally I prefer the Github workflow, but I believe there have been > some

Re: Proposal to switch to pull requests

2014-03-05 Thread Brock Noland
Personally I prefer the Github workflow, but I believe there have been some challenges with that since the source for apache projects must be stored in apache source control (git or svn). Relevent: https://blogs.apache.org/infra/entry/improved_integration_between_apache_and On Wed, Mar 5, 2014 a

Proposal to switch to pull requests

2014-03-05 Thread kulkarni.swar...@gmail.com
Hello, Since we have a nice mirrored git repository for hive[1], any specific reason why we can't switch to doing pull requests instead of patches? IMHO pull requests are awesome for peer review plus it is also very easy to keep track of JIRAs with open pull requests instead of looking for JIRAs i