Re: Review Request 47155: compute stats in certain cases fails with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47155/#review132474 --- Ship it! Ship It! - Vikram Dixit Kumaraswamy On May 10

Re: [ANNOUNCE] Apache Hive 2.0.0 Released

Great news indeed! Thanks Sergey! On 2/16/16, 11:54 AM, "Prasanth Jayachandran" wrote: >Great news! Thanks Sergey for the effort. > >Thanks >Prasanth > >> On Feb 16, 2016, at 1:44 PM, Sergey Shelukhin wrote: >> >> The Apache Hive team is proud to announce the the release of Apache Hive >> vers

Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime

079> Don't we need to refresh this session? It looks like the number of sessions in the queue can go down this way. - Vikram Dixit Kumaraswamy On Dec. 23, 2015, 1:30 a.m., Sergey Shelukhin wrote: > > --- > This is a

Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime

org/r/41431/#comment170940> Can you add more comments here explaining the states and how the interaction with the session pool occurs. - Vikram Dixit Kumaraswamy On Dec. 16, 2015, 1:57 a.m., Sergey Shelukhin wrote: > > ---

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

/ReduceRecordProcessor.java (line 235) <https://reviews.apache.org/r/34059/#comment146398> This will likely fail when we have a vectorized shuffle join. Can you add a note about needing to fix this in case we add a vectorized shuffle join. - Vikram Dixit Kumaraswamy On July 10, 2015, 10:17 p.m., Jaso

Re: Review Request 36486: HIVE-11262 Skip MapJoin processing if the join hash table is empty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36486/#review91926 --- Ship it! Ship It! - Vikram Dixit Kumaraswamy On July 16, 2015

Re: Review Request 34059: HIVE-10673 Dynamically partitioned hash join for Tez

this is correct? Shouldn't this be true only if this is dynamically partitioned hash join? ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java (line 652) <https://reviews.apache.org/r/34059/#comment141884> Is there ">>"

Re: Review Request 30788: HIVE-9617 UDF from_utc_timestamp throws NPE if the second argument is null

/GenericUDFFromUtcTimestamp.java <https://reviews.apache.org/r/30788/#comment117957> Don't we need the null check still for the arguments array? arguments[1] != null - Vikram Dixit Kumaraswamy On Feb. 11, 2015, 8:42 p.m., Alexander Pivo

Re: Review Request 30786: HIVE-6069 Improve error message in GenericUDFRound

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30786/#review72015 --- Ship it! Ship It! - Vikram Dixit Kumaraswamy On Feb. 9, 2015, 6

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24627/#review53087 --- Ship it! Ship It! - Vikram Dixit Kumaraswamy On Sept. 9, 2014

Re: Review Request 24627: HIVE-7704: Create tez task for fast file merging

What purpose does this class serve? Doesn't look like it does anything. Comments please. - Vikram Dixit Kumaraswamy On Sept. 6, 2014, 2:03 a.m., Prasanth_J wrote: > > --- > This i

Re: Review Request 23967: Enable auto conversion of SMBjoin in presence of constant propagate optimization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23967/#review48907 --- Ship it! Ship It! - Vikram Dixit Kumaraswamy On July 27, 2014

Re: Review Request 19789: HIVE-6739 Hive HBase query fails on Tez due to missing jars and then due to NPE in getSplits

/reviews.apache.org/r/19789/#comment71936> Open a jira for this. ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java <https://reviews.apache.org/r/19789/#comment71938> Aren't you walking the work graph here to populate the job conf? - Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

/apache/hive/service/server/HiveServer2.java 8700c5b Diff: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

service/src/java/org/apache/hive/service/server/HiveServer2.java 8700c5b Diff: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

service/src/java/org/apache/hive/service/server/HiveServer2.java 8700c5b Diff: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

PRE-CREATION service/src/java/org/apache/hive/service/server/HiveServer2.java 8700c5b Diff: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

lt sessions would let go of that. - Vikram ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17471/#review33496 --- On Jan. 28,

Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez

/server/HiveServer2.java fa13783 Diff: https://reviews.apache.org/r/17471/diff/ Testing --- Added multi-threaded junit tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 16728: Implement non-staged MapJoin

ent61882> can it be only these 2 operators? Maybe common join operator can be used? - Vikram Dixit Kumaraswamy On Jan. 20, 2014, 5 a.m., Navis Ryu wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 16440: HIVE-6098: Merge Tez branch into trunk

nterStatsAggregatorTez.java <https://reviews.apache.org/r/16440/#comment59838> Could add some documentation explaining the use of this class. trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java <https://reviews.apache.org/r/16440/#comment59839> Coul

Re: Review Request 16213: HIVE-5973: SMB joins produce incorrect results with multiple partitions and buckets

sting --- New test case added. Thanks, Vikram Dixit Kumaraswamy

Review Request 16213: HIVE-5973: SMB joins produce incorrect results with multiple partitions and buckets

/DummyStoreOperator.java acdb040 ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q PRE-CREATION ql/src/test/results/clientpositive/auto_sortmerge_join_16.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16213/diff/ Testing --- New test case added. Thanks, Vikram Dixit

Review Request 15543: HIVE-5827: Incorrect location of logs for failed tests.

/templates/TestParseNegative.vm 1aec083 Diff: https://reviews.apache.org/r/15543/diff/ Testing --- Ran failing tests and verified the message. Thanks, Vikram Dixit Kumaraswamy

Review Request 15069: HIVE-5685: partition column type validation doesn't work in some cases

q PRE-CREATION ql/src/test/results/clientnegative/illegal_partition_type3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/15069/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14651: HIVE-5543 - Running the mini tez cluster for tez unit tests

14651/#comment53493> Fixed. shims/src/0.23/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java <https://reviews.apache.org/r/14651/#comment53494> Fixed. - Vikram Dixit Kumaraswamy On Oct. 15, 2013, 9:50 p.m., Vikram Dixit Kumaraswamy wrote: > >

Re: Review Request 14892: HIVE-5633: Perflogger broken due to HIVE-5403

ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 8276d4d Diff: https://reviews.apache.org/r/14892/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14892: HIVE-5633: Perflogger broken due to HIVE-5403

/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Review Request 14892: HIVE-5633: Perflogger broken due to HIVE-5403

://issues.apache.org/jira/browse/HIVE-5633 Repository: hive-git Description --- Perflogger broken due to HIVE-5403. Diffs - ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 8276d4d Diff: https://reviews.apache.org/r/14892/diff/ Testing --- Thanks, Vikram Dixit

Review Request 14877: HIVE-5625: Fix issue with metastore version restriction test.

/ Testing --- Ran all metastore tests. Thanks, Vikram Dixit Kumaraswamy

Review Request 14651: HIVE-5543 - Running the mini tez cluster for tez unit tests

-CREATION Diff: https://reviews.apache.org/r/14651/diff/ Testing --- Added new tests for running the tez mini cluster and a new test target. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14425: HIVE-5403: Move loading of filesystem, ugi, metastore client to hive session

ve/ql/metadata/Hive.java 0491f8b ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java f6b1491 Diff: https://reviews.apache.org/r/14425/diff/ Testing --- Does not affect any unit tests but all of them exercise this code path. Thanks, Vikram Dixit Kumaraswamy

Review Request 14425: HIVE-5403: Move loading of filesystem, ugi, metastore client to hive session

f6b1491 Diff: https://reviews.apache.org/r/14425/diff/ Testing --- Does not affect any unit tests but all of them exercise this code path. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14349: HIVE-5271: Convert join op to a map join op in the planning phase

pache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 31ca07a ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 7e51310 Diff: https://reviews.apache.org/r/14349/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing --- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Review Request 14349: HIVE-5271: Convert join op to a map join op in the planning phase

/TezCompiler.java 7e51310 Diff: https://reviews.apache.org/r/14349/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

/alter_partition_coltype.q.out fe16fdd ql/src/test/results/clientpositive/partition_type_check.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing --- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

egal_partition_type2.q.out PRE-CREATION ql/src/test/results/clientpositive/partition_type_check.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing --- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

rc/test/results/clientnegative/illegal_partition_type.q.out PRE-CREATION ql/src/test/results/clientnegative/illegal_partition_type2.q.out PRE-CREATION ql/src/test/results/clientpositive/partition_type_check.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing --- Ran all

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

views.apache.org/r/14155/diff/ Testing --- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

s well. ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/14155/#comment51127> Cannot as I need to look up the key in different maps and the ordering cannot be guaranteed. - Vikram Dixit Kumaraswamy On Sept. 17, 2013, 9:08 a.m., Vi

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

rc/test/results/clientpositive/partition_type_check.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing --- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

rc/test/results/clientpositive/partition_type_check.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing --- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Review Request 14155: HIVE-5297 Hive does not honor type for partition columns

rc/test/results/clientpositive/partition_type_check.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14155/diff/ Testing --- Ran all tests. Thanks, Vikram Dixit Kumaraswamy

Review Request 13787: HIVE-5095: Hive needs new operator walker for parallelization/optimization for tez

/hadoop/hive/ql/plan/PlanUtils.java 5fd8d828 Diff: https://reviews.apache.org/r/13787/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

/diff/ Testing --- Runs the test from HIVE-4692 successfully. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

test from HIVE-4692 successfully. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

l/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a39fd21 Diff: https://reviews.apache.org/r/13697/diff/ Testing --- Runs the test from HIVE-4692 successfully. Thanks, Vikram Dixit Kumaraswamy

Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

/diff/ Testing --- Runs the test from HIVE-4692 successfully. Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 12827: HIVE-4611 - SMB joins fail based on bigtable selection policy.

ative/auto_sortmerge_join_1.q.out 0eddb69 ql/src/test/results/clientnegative/smb_bucketmapjoin.q.out 7a5b8c1 ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out PRE-CREATION Diff: https://reviews.apache.org/r/12827/diff/ Testing --- All tests pass on hadoop 1. Thanks, Vikram

Re: Review Request 13555: HIVE-5052: Set parallelism when generating the tez tasks

/hadoop/hive/ql/exec/Utilities.java edb55fa ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWork.java 48145ad Diff: https://reviews.apache.org/r/13555/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Review Request 13555: HIVE-5052: Set parallelism when generating the tez tasks

/parse/GenTezWork.java 48145ad Diff: https://reviews.apache.org/r/13555/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Review Request 13507: HIVE-5003: Localize hive exec jar for tez

/ErrorMsg.java 12e9334 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java faa99f7 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java ac536e2 Diff: https://reviews.apache.org/r/13507/diff/ Testing --- Thanks, Vikram Dixit Kumaraswamy

Re: Review Request 12827: HIVE-4611 - SMB joins fail based on bigtable selection policy.

ative/auto_sortmerge_join_1.q.out 0eddb69 ql/src/test/results/clientnegative/smb_bucketmapjoin.q.out 7a5b8c1 ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out PRE-CREATION Diff: https://reviews.apache.org/r/12827/diff/ Testing --- All tests pass on hadoop 1. Thanks, Vikram

Review Request 13032: HIVE-4826 Setup build infrastructure for tez

shims/ivy.xml 04ef641 Diff: https://reviews.apache.org/r/13032/diff/ Testing --- All unit tests pass. Thanks, Vikram Dixit Kumaraswamy

Review Request 12894: HIVE-4910: Hadoop 2 archives broken

/diff/ Testing --- Unit tests pass. Thanks, Vikram Dixit Kumaraswamy

Review Request 12827: HIVE-4611 - SMB joins fail based on bigtable selection policy.

/src/test/results/clientnegative/smb_bucketmapjoin.q.out 7a5b8c1 ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out PRE-CREATION Diff: https://reviews.apache.org/r/12827/diff/ Testing --- All tests pass on hadoop 1. Thanks, Vikram Dixit Kumaraswamy