----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30788/#review72023 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java <https://reviews.apache.org/r/30788/#comment117957> Don't we need the null check still for the arguments array? arguments[1] != null - Vikram Dixit Kumaraswamy On Feb. 11, 2015, 8:42 p.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30788/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 8:42 p.m.) > > > Review request for hive, Jason Dere, Siying Dong, and Vikram Dixit > Kumaraswamy. > > > Bugs: HIVE-9617 > https://issues.apache.org/jira/browse/HIVE-9617 > > > Repository: hive-git > > > Description > ------- > > HIVE-9617 UDF from_utc_timestamp throws NPE if the second argument is null > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFromUtcTimestamp.java > f76fc104774cf77597d8467c9dcf3fe8d05cddce > > Diff: https://reviews.apache.org/r/30788/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
