Re: [VOTE] Apache Hive 2.3.10 Release Candidate 1

2024-05-07 Thread Szehon Ho
.10.jar:2.3.10] at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317) ~[hive-exec-2.3.10.jar:2.3.10] at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1295) ~[hive-exec-2.3.10.jar:2.3.10] Thanks Szehon On Tue, May 7, 2024 at 1:11 AM Rui Li wrote: > +1 (b

Re: [VOTE] Apache Hive 3.1.3 Release Candidate 3

2022-04-06 Thread Szehon Ho
+1 (binding) Downloaded and ran create , insert, simple query on postgres. Verified checksums. Built from source. Thanks, Szehon On Mon, Apr 4, 2022 at 7:56 AM Naveen Gangam wrote: > *[No new commits from RC2]. Just cleaned up **apache-hive-3.1.3-src.tar.gz* > *archive* > > &

[jira] [Created] (HIVE-25991) Backport HIVE-25522 to branch-3

2022-02-28 Thread Szehon Ho (Jira)
Szehon Ho created HIVE-25991: Summary: Backport HIVE-25522 to branch-3 Key: HIVE-25991 URL: https://issues.apache.org/jira/browse/HIVE-25991 Project: Hive Issue Type: Bug Components

Re: Start releasing the master branch

2022-02-09 Thread Szehon Ho
+1 that would be awesome to see Hive master released after so long. Either 4.0 or 4.0.0-alpha-1 makes sense to me, not sure how we would pick any 3.x or calendar date (which could tend to slip and be more confusing?). Thanks in any case to get the ball rolling. Szehon On Wed, Feb 9, 2022 at 4

[jira] [Created] (HIVE-25522) NullPointerException in TxnHandler

2021-09-14 Thread Szehon Ho (Jira)
Szehon Ho created HIVE-25522: Summary: NullPointerException in TxnHandler Key: HIVE-25522 URL: https://issues.apache.org/jira/browse/HIVE-25522 Project: Hive Issue Type: Improvement

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

2021-07-21 Thread Szehon Ho
+1 (binding) * Built module * Ran tests * Checked artifact checksum and signature Thanks Szehon On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley wrote: > I think we should go ahead and release storage-api 2.8.0 and catch it on > the next cycle. HIVE-25190 is a long standing bug

Re: [VOTE] Apache Hive 2.3.9 Release Candidate 0

2021-06-07 Thread Szehon Ho
+1 Verified checksums, build from source, create db/table, populate data, ran some queries. Thanks Szehon On Fri, Jun 4, 2021 at 10:07 AM Xuefu Zhang wrote: > +1. Thank Chao for doing this. I performed the following actions: > > 1. Downloaded the release candidate artifacts and ver

Re: [VOTE] Apache Hive 2.3.8 Release Candidate 3

2021-01-12 Thread Szehon Ho
+1 Verified signatures Created a table, insert data, ran simple queries. Thanks Chao, Szehon On Mon, Jan 11, 2021 at 5:43 AM Xuefu Zhang wrote: > +1. I performed the following: > > 1. Downloaded bin and src tarball and verified signature and checksum > 2. Freshly initiated a

[jira] [Created] (HIVE-24263) Create an HMS endpoint to list partition locations

2020-10-12 Thread Szehon Ho (Jira)
Szehon Ho created HIVE-24263: Summary: Create an HMS endpoint to list partition locations Key: HIVE-24263 URL: https://issues.apache.org/jira/browse/HIVE-24263 Project: Hive Issue Type

[jira] [Created] (HIVE-24051) Hive lineage information exposed in ExecuteWithHookContext

2020-08-19 Thread Szehon Ho (Jira)
Szehon Ho created HIVE-24051: Summary: Hive lineage information exposed in ExecuteWithHookContext Key: HIVE-24051 URL: https://issues.apache.org/jira/browse/HIVE-24051 Project: Hive Issue Type

[jira] [Created] (HIVE-21033) Sudden disconnect for a session with set and SQL operation cuts off any more HiveServer2 logs

2018-12-12 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-21033: Summary: Sudden disconnect for a session with set and SQL operation cuts off any more HiveServer2 logs Key: HIVE-21033 URL: https://issues.apache.org/jira/browse/HIVE-21033

[jira] [Created] (HIVE-20789) HiveServer2 should have Timeouts against clients that never close sockets

2018-10-23 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-20789: Summary: HiveServer2 should have Timeouts against clients that never close sockets Key: HIVE-20789 URL: https://issues.apache.org/jira/browse/HIVE-20789 Project: Hive

[jira] [Created] (HIVE-20153) Count and Sum UDF consume more memory in Hive 2+

2018-07-12 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-20153: Summary: Count and Sum UDF consume more memory in Hive 2+ Key: HIVE-20153 URL: https://issues.apache.org/jira/browse/HIVE-20153 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-19767) HiveServer2 should take hiveconf for non Hive properties

2018-06-01 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-19767: Summary: HiveServer2 should take hiveconf for non Hive properties Key: HIVE-19767 URL: https://issues.apache.org/jira/browse/HIVE-19767 Project: Hive Issue Type

[jira] [Created] (HIVE-18347) Allow dynamic lookup of Hive Metastores via Consul

2017-12-29 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-18347: Summary: Allow dynamic lookup of Hive Metastores via Consul Key: HIVE-18347 URL: https://issues.apache.org/jira/browse/HIVE-18347 Project: Hive Issue Type: New

Re: Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

2016-10-20 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/#review153432 --- Ship it! Sorry for the delay, lgtm - Szehon Ho On Oct. 17

Re: Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

2016-10-13 Thread Szehon Ho
145) <https://reviews.apache.org/r/52079/#comment221635> Helper method for this? - Szehon Ho On Oct. 3, 2016, 1:31 p.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-28 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review150736 --- Ship it! Ship It! - Szehon Ho On Sept. 28, 2016, 2:12 p.m

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-27 Thread Szehon Ho
es even less sense, if we decrement by 1, we would be setting to one. - Szehon Ho On Sept. 21, 2016, 3:20 p.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 48839: HIVE-14029: Update Spark version to 2.0.0

2016-09-20 Thread Szehon Ho
2.0.0 is the version in pom) - Szehon Ho On June 17, 2016, 8:52 a.m., cheng xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Szehon Ho
was always hard to understand, and this makes it a little easier. I'll defer to Chaoyu to the comments. - Szehon Ho On Sept. 20, 2016, 7:39 p.m., Illya Yalovyy wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 50896: HIVE-14404: Allow delimiterfordsv to use multiple-character delimiters

2016-08-09 Thread Szehon Ho
kward incompatibie other than adding a new flag? Thanks. - Szehon Ho On Aug. 8, 2016, 3:13 p.m., Marta Kuczora wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-01 Thread Szehon Ho
there some instances that it did not work as expected? Thanks for the patch, some comments/questions. - Szehon Ho On July 1, 2016, 3:08 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

[Announce] New Hive Committer - Mohit Sabharwal

2016-07-01 Thread Szehon Ho
On behalf of the Apache Hive PMC, I'm pleased to announce that Mohit Sabharwal has been voted a committer on the Apache Hive project. Please join me in congratulating Mohit ! Thanks, Szehon

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-20 Thread Szehon Ho
> On June 17, 2016, 10:20 p.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 3179 > > <https://reviews.apache.org/r/48233/diff/5/?file=1422446#file1422446line3179> > > > > I actually meant here

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-17 Thread Szehon Ho
g/r/48233/#comment203497> I actually meant here to get rid of these checks as well (in the two checkLimitNumberOfPartitionByX methods) - Szehon Ho On June 17, 2016, 3:18 p.m., Sergio Pena wrote: > > --- > This is an auto

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 780 > > <https://reviews.apache.org/r/48233/diff/4/?file=1421506#file1421506line780> > > > > Should we add this to 'metaVars' variab

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 4793 > > <https://reviews.apache.org/r/48233/diff/4/?file=1421507#file1421507line4793> > > > > Should fix t

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
> On June 16, 2016, 9:24 p.m., Szehon Ho wrote: > > Mostly looks good, just some nits. - Szehon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48233/#rev

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-16 Thread Szehon Ho
eturn; that way we don't have to have the extra checks around this method. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 4792) <https://reviews.apache.org/r/48233/#comment203302> Should fix this? - Szehon Ho

[jira] [Created] (HIVE-13530) Hive on Spark throws Kryo exception in some cases

2016-04-15 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13530: Summary: Hive on Spark throws Kryo exception in some cases Key: HIVE-13530 URL: https://issues.apache.org/jira/browse/HIVE-13530 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-13517) Hive logs in Spark Executor and Driver should show thread-id.

2016-04-14 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13517: Summary: Hive logs in Spark Executor and Driver should show thread-id. Key: HIVE-13517 URL: https://issues.apache.org/jira/browse/HIVE-13517 Project: Hive Issue

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-13 Thread Szehon Ho
pRedLocalTask that runs out of process, this will not show the progress. - Szehon Ho On April 6, 2016, 9:57 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: recent metastore failures in HiveQA

2016-04-12 Thread Szehon Ho
e. On Tue, Apr 12, 2016 at 12:35 AM, Thejas Nair wrote: > Created a patch that should hopefully help in figuring out whats going > on - https://issues.apache.org/jira/browse/HIVE-13491 > > > On Wed, Apr 6, 2016 at 1:56 PM, Szehon Ho wrote: > > Yea thanks for point it out.

Re: [discuss] jdk8 support

2016-04-11 Thread Szehon Ho
Sounds like a good plan, +1 On Mon, Apr 11, 2016 at 4:31 PM, Mohit Sabharwal wrote: > Thanks, Ashutosh. Makes sense to keep the source and target as 1.7 since > we're not using any JDK8 specific features yet. So, option (3) essentially > just means using JDK8 exclusively to build & test Hive2. >

[jira] [Created] (HIVE-13457) Create HS2 REST API endpoints for monitoring information

2016-04-07 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13457: Summary: Create HS2 REST API endpoints for monitoring information Key: HIVE-13457 URL: https://issues.apache.org/jira/browse/HIVE-13457 Project: Hive Issue Type

Re: recent metastore failures in HiveQA

2016-04-06 Thread Szehon Ho
Yea thanks for point it out. I see it too and am not able to reproduce it locally. It points to an environment issue, but not aware anything changed with the environment. Anyone have any ideas? On Wed, Apr 6, 2016 at 1:29 PM, Sergey Shelukhin wrote: > Has anyone else noticed that many tests t

[jira] [Created] (HIVE-13420) Clarify HS2 WebUI Query 'Elapsed TIme'

2016-04-04 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13420: Summary: Clarify HS2 WebUI Query 'Elapsed TIme' Key: HIVE-13420 URL: https://issues.apache.org/jira/browse/HIVE-13420 Project: Hive Issue Type: I

[jira] [Created] (HIVE-13410) PerfLog metrics scopes not closed if there are exceptions on HS2

2016-04-01 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13410: Summary: PerfLog metrics scopes not closed if there are exceptions on HS2 Key: HIVE-13410 URL: https://issues.apache.org/jira/browse/HIVE-13410 Project: Hive Issue

[jira] [Created] (HIVE-13376) HoS emits too many logs with application state

2016-03-29 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13376: Summary: HoS emits too many logs with application state Key: HIVE-13376 URL: https://issues.apache.org/jira/browse/HIVE-13376 Project: Hive Issue Type: Improvement

Re: Failing tests, precommit test runtimes

2016-03-28 Thread Szehon Ho
Yea we looked at it before.. its tracked by HIVE-13223, caused by HIVE-13040. Because it hangs these tests take 2 hours max now before they are killed, hence each run taking over 3 hours. Ashutosh is looking I believe, I havent had a chance to take a look myself. Szehon On Mon, Mar 28, 2016 at

[jira] [Created] (HIVE-13355) SparkCliDriver tests frequently timeout

2016-03-24 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13355: Summary: SparkCliDriver tests frequently timeout Key: HIVE-13355 URL: https://issues.apache.org/jira/browse/HIVE-13355 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-13300) Hive on spark throws exception for multi-insert

2016-03-19 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13300: Summary: Hive on spark throws exception for multi-insert Key: HIVE-13300 URL: https://issues.apache.org/jira/browse/HIVE-13300 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-13301) Hive on spark local mode broken

2016-03-19 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13301: Summary: Hive on spark local mode broken Key: HIVE-13301 URL: https://issues.apache.org/jira/browse/HIVE-13301 Project: Hive Issue Type: Bug Components

Re: [Discuss] MariaDB support

2016-03-18 Thread Szehon Ho
dea > > On Wed, Mar 16, 2016 at 10:00 PM, Thejas Nair > wrote: > >> + Sergio, Szehon, Ashutosh, Sushanth, Sergey, >> >> Any thoughts on this ? >> >> >> On Tue, Mar 15, 2016 at 7:08 PM, Thejas Nair >> wrote: >> > There seems to be incre

[jira] [Created] (HIVE-13314) Hive on spark mapjoin errors if spark.master is not set

2016-03-18 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13314: Summary: Hive on spark mapjoin errors if spark.master is not set Key: HIVE-13314 URL: https://issues.apache.org/jira/browse/HIVE-13314 Project: Hive Issue Type: Bug

Re: [ANNOUNCE] New Hive Committer - Wei Zheng

2016-03-09 Thread Szehon Ho
Congratulations Wei! On Wed, Mar 9, 2016 at 5:26 PM, Vikram Dixit K wrote: > The Apache Hive PMC has voted to make Wei Zheng a committer on the Apache > Hive Project. Please join me in congratulating Wei. > > Thanks > Vikram. >

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-09 Thread Szehon Ho
, rootTasks was cached, so there wouldn't be a period of time of empty tasks, I missed seeing that. Thanks a lot for considering the suggestion and reducing duplication in the code. Patch looks great to me. - Szehon Ho On March 9, 2016, 3:03 p.m., Rajat Khandelwal

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-07 Thread Szehon Ho
/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java (line 1) <https://reviews.apache.org/r/44453/#comment184353> I dont see where this thrift class is defined or used? Same for JobTrackerState, ThriftHive, etc.. - Szehon Ho On March 7, 2016, 2:43 p.m.,

[jira] [Created] (HIVE-13217) Replication for HoS mapjoin small file needs to respect dfs.replication.max

2016-03-07 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13217: Summary: Replication for HoS mapjoin small file needs to respect dfs.replication.max Key: HIVE-13217 URL: https://issues.apache.org/jira/browse/HIVE-13217 Project: Hive

Re: Review Request 44271: HIVE-12270 : Add DBTokenStore support to HS2 delegation token

2016-03-03 Thread Szehon Ho
ect as its designed to be thread-local, but it's better than risking HMS leaks. Sorry for the long discussion with you about it. - Szehon Ho On March 4, 2016, 3:24 a.m., Chaoyu Tang wrote: > > --- > This is an automatically ge

Re: Review Request 44271: HIVE-12270 : Add DBTokenStore support to HS2 delegation token

2016-03-03 Thread Szehon Ho
> On March 4, 2016, 12:37 a.m., Szehon Ho wrote: > > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java, line 129 > > <https://reviews.apache.org/r/44271/diff/2/?file=1277523#file1277523line129> > > > > I'm a bit afraid of concurrency i

Re: Review Request 44271: HIVE-12270 : Add DBTokenStore support to HS2 delegation token

2016-03-03 Thread Szehon Ho
ad once its done? - Szehon Ho On March 2, 2016, 4:39 p.m., Chaoyu Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 42134: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-02 Thread Szehon Ho
kOperationCompletedTime(), check if state is terminal state and set the time there. Same comment across all operations.. - Szehon Ho On March 2, 2016, 11:44 a.m., Akshay Goyal wrote: > > --- > This is an automatically g

[jira] [Created] (HIVE-13171) Add unit test for hs2 webui

2016-02-26 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-13171: Summary: Add unit test for hs2 webui Key: HIVE-13171 URL: https://issues.apache.org/jira/browse/HIVE-13171 Project: Hive Issue Type: Sub-task Reporter

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

2016-02-01 Thread Szehon Ho
es/hive-webapps/static/js/tab.js PRE-CREATION Diff: https://reviews.apache.org/r/43008/diff/ Testing --- Manual testing. Can add some unit tests in follow-up. Thanks, Szehon Ho

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

2016-02-01 Thread Szehon Ho
uery.min.js PRE-CREATION service/src/resources/hive-webapps/static/js/tab.js PRE-CREATION Diff: https://reviews.apache.org/r/43008/diff/ Testing --- Manual testing. Can add some unit tests in follow-up. Thanks, Szehon Ho

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

2016-02-01 Thread Szehon Ho
, Aihua Xu wrote: > > service/src/resources/hive-webapps/static/js/tab.js, line 29 > > <https://reviews.apache.org/r/43008/diff/2/?file=1228436#file1228436line29> > > > > Remove the spaces here and below. Done - Szehon ---

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

2016-02-01 Thread Szehon Ho
rocess than HS2. - Szehon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43008/#review117098 --- On Feb. 1, 2016, 8:05 p.m.,

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

2016-02-01 Thread Szehon Ho
t; > <https://reviews.apache.org/r/43008/diff/1/?file=1227029#file1227029line98> > > > > setClosed()? Done > On Jan. 30, 2016, 6:28 a.m., Lenni Kuff wrote: > > service/src/java/org/apache/hive/service/cl

Re: Review Request 43008: HIVE-12952 : Show query sub-pages on webui

2016-02-01 Thread Szehon Ho
rg/r/43008/diff/ Testing --- Manual testing. Can add some unit tests in follow-up. Thanks, Szehon Ho

Review Request 43008: HIVE-12952 : Show query sub-pages on webui

2016-01-29 Thread Szehon Ho
Manual testing. Can add some unit tests in follow-up. Thanks, Szehon Ho

precommit outage due to github

2016-01-28 Thread Szehon Ho
Hi all, There seems to have been a HiveQA outage due to inability to check out from the hive github, which had gone down for a bit of time. Now its back up and running, but may have missed some patches during the interim. Thanks Szehon

[jira] [Created] (HIVE-12952) Show query sub-pages on webui

2016-01-27 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12952: Summary: Show query sub-pages on webui Key: HIVE-12952 URL: https://issues.apache.org/jira/browse/HIVE-12952 Project: Hive Issue Type: Sub-task Components

Re: [CONF] Apache Hive > Presentations

2016-01-27 Thread Szehon Ho
Yea makes sense to me (esp as "Older Presentations" are already at the bottom). I thought it had been in reverse order at one point. On Wed, Jan 27, 2016 at 11:41 AM, Sergey Shelukhin wrote: > Btw, would it make sense to keep the page in reverse chronological order, > to have the recent stuff o

Re: Review Request 42777: HIVE-12550 : Cache and display last N completed queries in HS2 WebUI

2016-01-27 Thread Szehon Ho
--- Manual testing, with screenshot attached. Thanks, Szehon Ho

Re: Review Request 42858: HIVE-12944: Support SUM(DISTINCT) for partitioning query.

2016-01-27 Thread Szehon Ho
ttps://reviews.apache.org/r/42858/#comment177680> Same ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java (line 450) <https://reviews.apache.org/r/42858/#comment177681> Same - Szehon Ho On Jan.

Re: Review Request 42777: HIVE-12550 : Cache and display last N completed queries in HS2 WebUI

2016-01-26 Thread Szehon Ho
ached. Thanks, Szehon Ho

Review Request 42777: HIVE-12550 : Cache and display last N completed queries in HS2 WebUI

2016-01-25 Thread Szehon Ho
org/apache/hive/service/cli/operation/SQLOperationInfo.java PRE-CREATION service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp a91b008 Diff: https://reviews.apache.org/r/42777/diff/ Testing --- Manual testing, with screenshot attached. Thanks, Szehon Ho

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-25 Thread Szehon Ho
. Just a small nit below on the comment, can fix it on commit. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java (line 119) <https://reviews.apache.org/r/42508/#comment177219> What is manager? And also nit to remove the whitespace at end. - Szehon Ho On J

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-22 Thread Szehon Ho
/GenericUDAFCount.java (line 160) <https://reviews.apache.org/r/42508/#comment176986> Chatted with Aihua offline, following the example of the similar function GenericUDAFMin/Max will be easier :) - Szehon Ho On Jan. 20, 2016, 5:05 p.m., Aihua Xu

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-22 Thread Szehon Ho
that also need it? - Szehon Ho On Jan. 20, 2016, 5:05 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42508/ > -

[jira] [Created] (HIVE-12868) Fix empty operation-pool metrics

2016-01-13 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12868: Summary: Fix empty operation-pool metrics Key: HIVE-12868 URL: https://issues.apache.org/jira/browse/HIVE-12868 Project: Hive Issue Type: Bug Components

Re: HiveQA fails due to full disk

2016-01-07 Thread Szehon Ho
Just cleaned up some space by deleting old build logs, hope it goes through now. On Thu, Jan 7, 2016 at 10:36 AM, Sergey Shelukhin wrote: > Looks like lots of builds are failing with: > fatal: sha1 file '.git/objects/pack/tmp_pack_nm4WS4' write error: No space > left on device > > The last one I

Re: Is Jenkins down?

2016-01-04 Thread Szehon Ho
Thanks Pengcheng, somehow the Precommit Admin (the job that queries JIRA) got stuck exactly at new years. I killed the job and restarted, now at least that part goes fine. A bunch of jobs are now submitted including yours, let's see if that part works ok. Thanks, Szehon On Mon, Jan 4, 20

Re: Is Jenkins down?

2016-01-04 Thread Szehon Ho
Hi Pengcheng, thanks for reporting it.. do you have a patch you can point me to? I'll take a look. Szehon On Mon, Jan 4, 2016 at 1:44 PM, Pengcheng Xiong wrote: > Hi all, > > I submitted several patches but none of them got run. It seems that > Jenkins is down. The las

[jira] [Created] (HIVE-12757) Fix TestCodahaleMetrics#testFileReporting

2015-12-29 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12757: Summary: Fix TestCodahaleMetrics#testFileReporting Key: HIVE-12757 URL: https://issues.apache.org/jira/browse/HIVE-12757 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-12733) UX improvements for HIVE-12499

2015-12-22 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12733: Summary: UX improvements for HIVE-12499 Key: HIVE-12733 URL: https://issues.apache.org/jira/browse/HIVE-12733 Project: Hive Issue Type: Sub-task

Review Request 41164: HIVE-12628 : Eliminate flakiness in TestMetrics

2015-12-09 Thread Szehon Ho
/service/cli/session/TestSessionManagerMetrics.java aaeecbe Diff: https://reviews.apache.org/r/41164/diff/ Testing --- Thanks, Szehon Ho

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

2015-12-08 Thread Szehon Ho
> On Dec. 8, 2015, 10:43 p.m., Szehon Ho wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1861 > > <https://reviews.apache.org/r/41062/diff/1/?file=1155465#file1155465line1861> > > > > We can keep it lower-case to keep it consistent

[jira] [Created] (HIVE-12628) Eliminate flakiness in TestMetrics

2015-12-08 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12628: Summary: Eliminate flakiness in TestMetrics Key: HIVE-12628 URL: https://issues.apache.org/jira/browse/HIVE-12628 Project: Hive Issue Type: Test

Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos

2015-12-08 Thread Szehon Ho
1861) <https://reviews.apache.org/r/41062/#comment168921> We can keep it lower-case to keep it consistent. - Szehon Ho On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote: > > --- > This is an automatically generated e-mail.

[jira] [Created] (HIVE-12621) PTest Backup additional spark logs

2015-12-08 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12621: Summary: PTest Backup additional spark logs Key: HIVE-12621 URL: https://issues.apache.org/jira/browse/HIVE-12621 Project: Hive Issue Type: Test

Re: Review Request 40948: HIVE-12499 : Add HMS metrics for number of tables and partitions

2015-12-08 Thread Szehon Ho
ontrolledCommit.java 9a1d159 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af Diff: https://reviews.apache.org/r/40948/diff/ Testing --- Added unit tests for HBase and Db metastores. Thanks, Szehon Ho

Re: Review Request 40948: HIVE-12499 : Add HMS metrics for number of tables and partitions

2015-12-04 Thread Szehon Ho
then user needs to setup HCatalog and JMS and I wanted to keep this just in HMS layer. I thought the background thread is the best tradeoff, it will not always be accurate but the interval is configurable and a slow query should not matter as much with a

Re: Review Request 40948: HIVE-12499 : Add HMS metrics for number of tables and partitions

2015-12-04 Thread Szehon Ho
t; > DEBUG ? same for below.. That's true, but as its a new feature I wanted to enable logging by default so that user will know if this is causing an issue, and can disable it. - Szehon ---

Re: Review Request 40948: HIVE-12499 : Add HMS metrics for number of tables and partitions

2015-12-04 Thread Szehon Ho
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af Diff: https://reviews.apache.org/r/40948/diff/ Testing --- Added unit tests for HBase and Db metastores. Thanks, Szehon Ho

Review Request 40948: HIVE-12499 : Add HMS metrics for number of tables and partitions

2015-12-03 Thread Szehon Ho
tests for HBase and Db metastores. Thanks, Szehon Ho

[jira] [Created] (HIVE-12525) Cleanup unused metrics in HMS

2015-11-25 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12525: Summary: Cleanup unused metrics in HMS Key: HIVE-12525 URL: https://issues.apache.org/jira/browse/HIVE-12525 Project: Hive Issue Type: Bug Reporter

Re: not committing things that add HiveQA failures

2015-11-25 Thread Szehon Ho
Yea I thought that has always been the agreed policy, to wait until HiveQA doesn't report unexpected failures before checking in, it should be strictly followed. For fixing test/build, I think traditionally its nicer to first check with the author/committer of breaking patch if there is a simple f

Re: [ANNOUNCE] New PMC Member : John Pullokkaran

2015-11-24 Thread Szehon Ho
Congratulations! On Tue, Nov 24, 2015 at 3:02 PM, Xuefu Zhang wrote: > Congratulations, John! > > --Xuefu > > On Tue, Nov 24, 2015 at 3:01 PM, Prasanth J > wrote: > >> Congratulations and Welcome John! >> >> Thanks >> Prasanth >> >> On Nov 24, 2015, at 4:59 PM, Ashutosh Chauhan >> wrote: >> >>

[jira] [Created] (HIVE-12499) Add HMS metrics for number of tables and partitions

2015-11-23 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12499: Summary: Add HMS metrics for number of tables and partitions Key: HIVE-12499 URL: https://issues.apache.org/jira/browse/HIVE-12499 Project: Hive Issue Type: Sub

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

2015-11-23 Thread Szehon Ho
mment166304> One more comment, no need to put 'version', just 'When Hive version was compiled and by whom' - Szehon Ho On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote: > > --- > This is an aut

Re: Review Request 40318: HIVE-12271 : Add metrics around HS2 query execution and job submission for Hive

2015-11-16 Thread Szehon Ho
://reviews.apache.org/r/40318/diff/ Testing --- Added two unit tests: TestHs2Metrics, TestSessionManagerMetrics, test all of these metric categories in in-flight and post-operation metric counts. Thanks, Szehon Ho

Review Request 40318: HIVE-12271 : Add metrics around HS2 query execution and job submission for Hive

2015-11-13 Thread Szehon Ho
tests: TestHs2Metrics, TestSessionManagerMetrics, test all of these metric categories in in-flight and post-operation metric counts. Thanks, Szehon Ho

[jira] [Created] (HIVE-12330) Fix precommit Spark test part2

2015-11-03 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12330: Summary: Fix precommit Spark test part2 Key: HIVE-12330 URL: https://issues.apache.org/jira/browse/HIVE-12330 Project: Hive Issue Type: Bug Components

[jira] [Created] (HIVE-12296) Classcast exception when selecting constant in inner select

2015-10-29 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12296: Summary: Classcast exception when selecting constant in inner select Key: HIVE-12296 URL: https://issues.apache.org/jira/browse/HIVE-12296 Project: Hive Issue Type

Re: Review Request 39741: HIVE-12280 : HiveConnection does not try all possible HS2 in dynamic service discovery mode.

2015-10-29 Thread Szehon Ho
jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 6c21423 Diff: https://reviews.apache.org/r/39741/diff/ Testing --- Added unit test. Thanks, Szehon Ho

Review Request 39741: HIVE-12280 : HiveConnection does not try all possible HS2 in dynamic service discovery mode.

2015-10-28 Thread Szehon Ho
--- Added unit test. Thanks, Szehon Ho

[jira] [Created] (HIVE-12280) HiveConnection does not try all possible HS2 in dynamic service discovery mode.

2015-10-27 Thread Szehon Ho (JIRA)
Szehon Ho created HIVE-12280: Summary: HiveConnection does not try all possible HS2 in dynamic service discovery mode. Key: HIVE-12280 URL: https://issues.apache.org/jira/browse/HIVE-12280 Project: Hive

  1   2   3   4   5   6   7   8   9   10   >