----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/#review152576 -----------------------------------------------------------
Fix it, then Ship it! Looks good, just minor comments. Assume you've tested it service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 100) <https://reviews.apache.org/r/52079/#comment221634> Can we move this to a helper method? service/src/java/org/apache/hive/service/cli/session/SessionManager.java (line 145) <https://reviews.apache.org/r/52079/#comment221635> Helper method for this? - Szehon Ho On Oct. 3, 2016, 1:31 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52079/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 1:31 p.m.) > > > Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena. > > > Repository: hive-git > > > Description > ------- > > HIVE-14753: Track the number of open/closed/abandoned sessions in HS2 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java > ba2267b29eaeb497e9582ca3ff3de4ad63bf8482 > common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java > 9b263d91321f141adf73e5421f3d659f80081471 > > common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java > c9d4087c5aeaf7f1ca0e9b5860b898b5766cd911 > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java > 9525b452eada8ab6a2dd56895f9c9d4eb50db894 > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java > PRE-CREATION > common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java > 46676589e6656d0f13f1931bfe67a63dd1920042 > > common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 76e759f23fdbc60629397121fd2522e6e9251a85 > > service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java > 5511c54ff431211f7f72deaa017c915b839dfb2a > > Diff: https://reviews.apache.org/r/52079/diff/ > > > Testing > ------- > > Ran the unit tests in the common and the ql subprojects. > Manually verified the metrics using the HS2 webui metric dump. > > > Thanks, > > Barna Zsombor Klara > >
