----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42858/#review116607 -----------------------------------------------------------
Fix it, then Ship it! Good job, same logic as count(distinct). Dont have many useful comments, just very small code-style nits, can fix on commit. ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java (line 233) <https://reviews.apache.org/r/42858/#comment177677> Space after the cast for code-style consistency. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java (line 95) <https://reviews.apache.org/r/42858/#comment177678> Space after cast ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java (line 129) <https://reviews.apache.org/r/42858/#comment177676> TYPE should be T or Type for codestyle. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java (line 219) <https://reviews.apache.org/r/42858/#comment177679> Same ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java (line 336) <https://reviews.apache.org/r/42858/#comment177680> Same ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java (line 450) <https://reviews.apache.org/r/42858/#comment177681> Same - Szehon Ho On Jan. 27, 2016, 4:31 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42858/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 4:31 p.m.) > > > Review request for hive and Szehon Ho. > > > Repository: hive-git > > > Description > ------- > > HIVE-12944: Support SUM(DISTINCT) for partitioning query. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlSumAggFunction.java > 056eaeb0d707342185763dc5d5af900523e5512d > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 75c38fa0d30ec4a3fcf240b7f5d6e3c739a3aa17 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java > f526c437c21713b02f991ce3a8ee52a0dbd885a2 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java > 09680086ee25b3f512061cb60946b55db934345c > ql/src/test/queries/clientpositive/windowing_distinct.q > 94f4044b8a491e9e13ebe7fd879fd49715860e94 > ql/src/test/results/clientpositive/windowing_distinct.q.out > 50f8ff81934c6a9338e74e9e6d4116d5f2b3ba4b > > Diff: https://reviews.apache.org/r/42858/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
