Re: Review Request 22478: HIVE-7188 sum(if()) returns wrong results with vectorization

2014-06-11 Thread Jitendra Pandey
/ColAndCol.java <https://reviews.apache.org/r/22478/#comment80300> Please confirm hive semantics that NULL AND FALSE is FALSE and not NULL. - Jitendra Pandey On June 11, 2014, 9:23 p.m., Hari Sankar Sivarama Subramaniyan

Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-28 Thread Jitendra Pandey
between" operator? See previous one. - Jitendra ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/#review38958 --- On March 28, 2014, 9:56 p.m., Jitendra Pandey wrote: > >

Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-28 Thread Jitendra Pandey
itive/vector_between_in.q PRE-CREATION ql/src/test/results/clientpositive/vector_between_in.q.out PRE-CREATION Diff: https://reviews.apache.org/r/19718/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-27 Thread Jitendra Pandey
or_between_in.q PRE-CREATION ql/src/test/results/clientpositive/vector_between_in.q.out PRE-CREATION Diff: https://reviews.apache.org/r/19718/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.

2014-03-27 Thread Jitendra Pandey
sical/Vectorizer.java c2240c0 ql/src/test/queries/clientpositive/vector_between_in.q PRE-CREATION ql/src/test/results/clientpositive/vector_between_in.q.out PRE-CREATION Diff: https://reviews.apache.org/r/19718/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 19219: Vectorization: Partition column names are not picked up.

2014-03-14 Thread Jitendra Pandey
/CastDecimalToTimestamp.java 32386fe ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java c26da37 Diff: https://reviews.apache.org/r/19219/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 19218: Vectorization: some date expressions throw exception.

2014-03-14 Thread Jitendra Pandey
/clientpositive/vectorized_date_funcs.q 6c9515c ql/src/test/results/clientpositive/vectorized_date_funcs.q.out a9d7dde Diff: https://reviews.apache.org/r/19218/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 19216: Vectorized variance computation differs from row mode computation.

2014-03-14 Thread Jitendra Pandey
/UDAFTemplates/VectorUDAFVarDecimal.txt c5af930 ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 507f798 Diff: https://reviews.apache.org/r/19216/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 19216: Vectorized variance computation differs from row mode computation.

2014-03-14 Thread Jitendra Pandey
/test/results/clientpositive/vector_decimal_aggregate.q.out 507f798 Diff: https://reviews.apache.org/r/19216/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 18972: Vectorized cast of decimal to string and timestamp produces incorrect result.

2014-03-10 Thread Jitendra Pandey
/vector_decimal_expressions.q 38934d2 ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 629f5d5 Diff: https://reviews.apache.org/r/18972/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 18972: Vectorized cast of decimal to string and timestamp produces incorrect result.

2014-03-10 Thread Jitendra Pandey
://reviews.apache.org/r/18972/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 18808: Casting from decimal to tinyint, smallint, int and bigint generates different result when vectorization is on

2014-03-06 Thread Jitendra Pandey
/type/Decimal128.java a5d7399 common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 426c03d Diff: https://reviews.apache.org/r/18808/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 18808: Casting from decimal to tinyint, smallint, int and bigint generates different result when vectorization is on

2014-03-05 Thread Jitendra Pandey
/18808/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 18566: Queries fail to Vectorize.

2014-02-26 Thread Jitendra Pandey
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java db4eafa ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java e2529d2 Diff: https://reviews.apache.org/r/18566/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 18566: Queries fail to Vectorize.

2014-02-26 Thread Jitendra Pandey
ve/ql/udf/generic/GenericUDFOPMod.java db4eafa ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java e2529d2 Diff: https://reviews.apache.org/r/18566/diff/ Testing --- Thanks, Jitendra Pandey

Re: [ANNOUNCE] New Hive Committer - Remus Rusanu

2014-02-26 Thread Jitendra Pandey
Congratulations Remus! On Wed, Feb 26, 2014 at 11:10 AM, Lefty Leverenz wrote: > Congratulations Remus! > > -- Lefty > > > On Wed, Feb 26, 2014 at 12:23 PM, Thejas Nair >wrote: > > > Congrats Remus! > > > > > > > > On Wed, Feb 26, 2014 at 9:08 AM, Clay McDonald < > > stuart.mcdon...@bateswhite.

Review Request 18184: Vectorized mathematical functions for decimal type.

2014-02-17 Thread Jitendra Pandey
, Jitendra Pandey

Re: Review Request 18025: Implement vectorized support for COALESCE conditional expression

2014-02-13 Thread Jitendra Pandey
ql/src/test/queries/clientpositive/vector_coalesce.q PRE-CREATION ql/src/test/results/clientpositive/vector_coalesce.q.out PRE-CREATION Diff: https://reviews.apache.org/r/18025/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 18025: Implement vectorized support for COALESCE conditional expression

2014-02-13 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18025/#review34336 --- On Feb. 14, 2014, 1:49 a.m., Jitendra Pandey wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 18002: Add DECIMAL support to vectorized JOIN operators and vectorized aggregates

2014-02-12 Thread Jitendra Pandey
<https://reviews.apache.org/r/18002/#comment64408> The patch seems to have tab characters in many places. - Jitendra Pandey On Feb. 12, 2014, 12:30 p.m., Remus Rusanu wrote: > > --- > This is an automatically gener

Review Request 18025: Implement vectorized support for COALESCE conditional expression

2014-02-12 Thread Jitendra Pandey
/vector_coalesce.q PRE-CREATION ql/src/test/results/clientpositive/vector_coalesce.q.out PRE-CREATION Diff: https://reviews.apache.org/r/18025/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-10 Thread Jitendra Pandey
on and scale e.g. decimal(5,3). - Jitendra Pandey On Feb. 5, 2014, 11:04 a.m., Remus Rusanu wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-07 Thread Jitendra Pandey
/vectorization_short_regress.q.out 305d336 Diff: https://reviews.apache.org/r/17769/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-07 Thread Jitendra Pandey
tput. - Jitendra --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17769/#review33942 --- On Feb. 7, 2014, 2:31 a.m., Jitendra Pandey wrote: > >

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-06 Thread Jitendra Pandey
-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out 305d336 Diff: https://reviews.apache.org/r/17769/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-05 Thread Jitendra Pandey
/vector_decimal_expressions.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_decimal_date.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out 305d336 Diff: https://reviews.apache.org/r/17769/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 17769: Generate vectorized plan for decimal expressions.

2014-02-05 Thread Jitendra Pandey
/results/clientpositive/vectorization_decimal_date.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out 305d336 Diff: https://reviews.apache.org/r/17769/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 17622: VectorExpressionWriter for date and decimal datatypes.

2014-02-05 Thread Jitendra Pandey
o reply, visit: https://reviews.apache.org/r/17622/#review33378 ------- On Jan. 31, 2014, 10:19 p.m., Jitendra Pandey wrote: > > --- > This is an automatically generated e-

Review Request 17622: VectorExpressionWriter for date and decimal datatypes.

2014-01-31 Thread Jitendra Pandey
/vectorization_decimal_date.q PRE-CREATION ql/src/test/results/clientpositive/vectorization_decimal_date.q.out PRE-CREATION Diff: https://reviews.apache.org/r/17622/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-28 Thread Jitendra Pandey
0df82b9 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java 0d5b7ff Diff: https://reviews.apache.org/r/17005/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-27 Thread Jitendra Pandey
the decimal value to the expected scale if there is a mismatch. - Jitendra --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/#review32855 ------

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-27 Thread Jitendra Pandey
0df82b9 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java 0d5b7ff Diff: https://reviews.apache.org/r/17005/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-24 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/#review32299 --- On Jan. 24, 2014, 10:28 p.m., Jitendra Pandey wrote: > > -

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-24 Thread Jitendra Pandey
0df82b9 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java 0d5b7ff Diff: https://reviews.apache.org/r/17005/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-16 Thread Jitendra Pandey
/io/orc/TestVectorizedORCReader.java 0d5b7ff Diff: https://reviews.apache.org/r/17005/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 16760: Implement vectorized reader for Date datatype for ORC format.

2014-01-10 Thread Jitendra Pandey
/ql/io/orc/RecordReaderImpl.java 173fb8d ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java ef9b968 Diff: https://reviews.apache.org/r/16760/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 16760: Implement vectorized reader for Date datatype for ORC format.

2014-01-09 Thread Jitendra Pandey
/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java ef9b968 Diff: https://reviews.apache.org/r/16760/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 16760: Implement vectorized reader for Date datatype for ORC format.

2014-01-09 Thread Jitendra Pandey
/TestVectorizedORCReader.java ef9b968 Diff: https://reviews.apache.org/r/16760/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2014-01-02 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16229/#review31098 --- Ship it! Ship It! - Jitendra Pandey On Dec. 17, 2013, 10:40 p.m

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-16 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16229/#review30506 --- Ship it! Ship It! - Jitendra Pandey On Dec. 13, 2013, 7:15 p.m

Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution

2013-12-16 Thread Jitendra Pandey
test/queries/clientcompare/vectorized_math_funcs_00.qv <https://reviews.apache.org/r/16229/#comment58288> The name of the file could be suffixed to indicate vectorization disabled or enabled. - Jitendra Pandey On Dec. 13, 2013, 7:15 p.m., Serg

Re: Review Request 15495: Implement vectorization support for IF conditional expression for long and double inputs

2013-12-10 Thread Jitendra Pandey
/reviews.apache.org/r/15495/#comment57725> Null check for arg3ColVector. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprStringScalarStringColumn.java <https://reviews.apache.org/r/15495/#comment57726> Null check. - Jitendra Pandey On Dec. 9,

Re: Review Request 14956: Fix validation of nested expressions.

2013-10-28 Thread Jitendra Pandey
/TestVectorizer.java 51bc09a Diff: https://reviews.apache.org/r/14956/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 14956: Fix validation of nested expressions.

2013-10-25 Thread Jitendra Pandey
/VectorizationContext.java 4a9b870 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java e698870 ql/src/test/org/apache/hadoop/hive/ql/optimizer/physical/TestVectorizer.java 51bc09a Diff: https://reviews.apache.org/r/14956/diff/ Testing --- Thanks, Jitendra Pandey

Re: Proposal to move precommit testing to Bigtop Jenkins?

2013-10-22 Thread Jitendra Pandey
+1. That sounds great! On Tue, Oct 22, 2013 at 11:54 AM, Ashutosh Chauhan wrote: > +1 > Seems like a good idea to me. > > > On Fri, Oct 18, 2013 at 2:31 PM, Brock Noland wrote: > > > Our precommit jobs wait, sometimes for hours, before a Jenkins executor > is > > free. Meanwhile I noticed that

Re: Review Request 14576: NOT expression doesn't handle nulls correctly.

2013-10-21 Thread Jitendra Pandey
https://reviews.apache.org/r/14576/diff/ Testing --- File Attachments https://reviews.apache.org/media/uploaded/files/2013/10/21/HIVE-5430.6.patch Thanks, Jitendra Pandey

Re: Review Request 14576: NOT expression doesn't handle nulls correctly.

2013-10-21 Thread Jitendra Pandey
--- File Attachments https://reviews.apache.org/media/uploaded/files/2013/10/21/HIVE-5430.6.patch Thanks, Jitendra Pandey

Re: Review Request 14576: NOT expression doesn't handle nulls correctly.

2013-10-21 Thread Jitendra Pandey
sting --- File Attachments (updated) https://reviews.apache.org/media/uploaded/files/2013/10/21/HIVE-5430.6.patch Thanks, Jitendra Pandey

Re: VOTE: Remove phabricator instructions from hive-development guide (wiki), officially only support Apache's review board.

2013-10-17 Thread Jitendra Pandey
+1 (non-binding) On Thu, Oct 17, 2013 at 1:08 PM, Alan Gates wrote: > Major +1 (non-binding). Using 3rd party tools where we have no option for > support or help is not good. > > Alan. > > On Oct 16, 2013, at 5:32 PM, Edward Capriolo wrote: > > > Our wiki has instructions for posting to phabri

Review Request 14632: Vectorized query failing for partitioned tables.

2013-10-14 Thread Jitendra Pandey
/vectorization_part.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14632/diff/ Testing --- Thanks, Jitendra Pandey

Review Request 14576: NOT expression doesn't handle nulls correctly.

2013-10-10 Thread Jitendra Pandey
ion_8.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_9.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_not.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14576/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 14130: Merge vectorization branch to trunk

2013-09-24 Thread Jitendra Pandey
PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarSerDe.java 70bc7e8 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java ec91717 Diff: https://reviews.apache.org/r/14130/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 14130: Merge vectorization branch to trunk

2013-09-24 Thread Jitendra Pandey
/vectorized_rcfile_columnar.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarSerDe.java 70bc7e8 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java ec91717 Diff: https://reviews.apache.org/r/14130/diff/ Testing --- Thanks, Jitendra Pandey

Re: Review Request 14130: Merge vectorization branch to trunk

2013-09-18 Thread Jitendra Pandey
o reply, visit: https://reviews.apache.org/r/14130/#review26120 ------- On Sept. 13, 2013, 5:51 p.m., Jitendra Pandey wrote: > > --- > This is an automatically generated e-

Re: Review Request 14130: Merge vectorization branch to trunk

2013-09-18 Thread Jitendra Pandey
hed convention of checking these file > > instead of generating them since it serves as a useful canary for catching > > accidental changes to the ORC format. I have filed HIVE-5314 to address this. - Jitendra --

Review Request 14130: Merge vectorization branch to trunk

2013-09-13 Thread Jitendra Pandey
service/src/java/org/apache/hive/service/auth/CustomAuthenticationProviderImpl.java 7094b89 service/src/test/org/apache/hive/service/auth/TestCustomAuthentication.java 8db6313 Diff: https://reviews.apache.org/r/14130/diff/ Testing --- Thanks, Jitendra Pandey

Re: Merge vectorization branch to trunk

2013-09-09 Thread Jitendra Pandey
nt test test take in comparison with trunk? > What new modules or dependencies are added? > Can the feature be disabled if required? > > Brock > > On Fri, Sep 6, 2013 at 3:44 PM, Jitendra Pandey > wrote: > > Hi Folks, > >Vectorized query execution work has been

Merge vectorization branch to trunk

2013-09-06 Thread Jitendra Pandey
Hi Folks, Vectorized query execution work has been under development for around 6 months now. We have made good progress in making basic datatypes and queries to work in vectorized mode and also we have laid sufficient groundwork so that any future development can happen directly on trunk. Th

Re: Review Request: HIVE-4637 Fix VectorUDAFSum.txt to honor the expected vector column type

2013-05-31 Thread Jitendra Pandey
good idea to fix similar issue in other templates too. - Jitendra Pandey On May 31, 2013, 2:39 p.m., Remus Rusanu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [VOTE] Apache Hive 0.11.0 Release Candidate 2

2013-05-15 Thread Jitendra Pandey
+1 (non binding) Downloaded tar-ball, verified checksums, installed one node cluster and ran a few queries. On Wed, May 15, 2013 at 7:53 PM, Edward Capriolo wrote: > +1 > > > On Wed, May 15, 2013 at 10:44 PM, Ashutosh Chauhan >wrote: > > > +1 > > > > Built from sources, ran few unit tests and

Re: Branch for HIVE-4160

2013-04-08 Thread Jitendra Pandey
> Having said that, both approaches can be made to work - but I think you > are just delaying the > merging work instead of taking the hit upfront. > > Thanks, > -namit > > > > On 4/4/13 2:40 AM, "Jitendra Pandey" wrote: > > > We did consider imp

Re: Branch for HIVE-4160

2013-04-03 Thread Jitendra Pandey
ge on this. > I would recommend starting with simple interfaces for operators and then > plugging them > in slowly instead of a new branch, unless this approach is extremely > difficult. > > > Thanks, > -namit > > On 4/3/13 1:52 AM, "Jitendra Pandey" wrot

Branch for HIVE-4160

2013-04-02 Thread Jitendra Pandey
Hi Folks, I want to propose for creation of a separate branch for HIVE-4160 work. This is a significant amount of work, and support for very basic functionality will need big chunks of code. It will also take some time to stabilize and test. A separate dev branch will allow us to do this work