> On Feb. 13, 2014, 1:30 a.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java, > > line 440 > > <https://reviews.apache.org/r/18025/diff/1/?file=483651#file483651line440> > > > > This is the same code block as the previous case. Can you share the > > case and change the condition to an OR? > > > > Up to you...
This piece of code will be revisited in HIVE-6416, where I need to add casting for many mathematical functions. I will address it there. > On Feb. 13, 2014, 1:30 a.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorCoalesce.java, > > line 126 > > <https://reviews.apache.org/r/18025/diff/1/?file=483652#file483652line126> > > > > This can have > 1 argument. Please add comment to explain. > > > > This class should not return a descriptor, because it can take variable number of arguments with different data types. - Jitendra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18025/#review34336 ----------------------------------------------------------- On Feb. 14, 2014, 1:49 a.m., Jitendra Pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18025/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 1:49 a.m.) > > > Review request for hive and Eric Hanson. > > > Bugs: HIVE-5759 > https://issues.apache.org/jira/browse/HIVE-5759 > > > Repository: hive-git > > > Description > ------- > > Implement vectorized support for COALESCE conditional expression > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java > f1eef14 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 0a8811f > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DecimalColumnVector.java > d0d8597 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java > cb23129 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java > aa05b19 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 7141d63 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorCoalesce.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 21fe8ca > ql/src/test/queries/clientpositive/vector_coalesce.q PRE-CREATION > ql/src/test/results/clientpositive/vector_coalesce.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/18025/diff/ > > > Testing > ------- > > > Thanks, > > Jitendra Pandey > >
