----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18566/ -----------------------------------------------------------
(Updated Feb. 27, 2014, 6:43 a.m.) Review request for hive and Eric Hanson. Bugs: HIVE-6496 https://issues.apache.org/jira/browse/HIVE-6496 Repository: hive-git Description ------- 1) NPE because row resolver is null. 2) VectorUDFAdapter doesn't handle decimal. 3) Decimal cast to boolean, timestamp, string fail because classes are not annotated appropriately. 4) Decimal modulo fails to vectorize because GenericUDFOPMod is not annotated. Diffs ----- common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java 09af28a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java 4de9f9f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 842994e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/udf/VectorUDFAdaptor.java 3bc9493 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java e6be03f ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 54c665e ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java db4eafa ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java e2529d2 Diff: https://reviews.apache.org/r/18566/diff/ Testing ------- Thanks, Jitendra Pandey