[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997766#comment-17997766 ] Oleg Kalnichevski commented on HTTPCLIENT-2379: --- [~yhzdys] Good catch.

Re: [PR] Replace the old InputStreamFactory registries with the new Decoder / Encoder pipeline [httpcomponents-client]

2025-07-05 Thread via GitHub
ok2c commented on code in PR #660: URL: https://github.com/apache/httpcomponents-client/pull/660#discussion_r2187212706 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/compress/Decoder.java: ## @@ -0,0 +1,60 @@ +/* + *

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997768#comment-17997768 ] Oleg Kalnichevski commented on HTTPCLIENT-2379: --- [~abernal] Yes, exact

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997756#comment-17997756 ] Arturo Bernal commented on HTTPCLIENT-2379: --- [~olegk] Confirmed—applied yo

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997757#comment-17997757 ] Oleg Kalnichevski commented on HTTPCLIENT-2379: --- [~abernal] Feel free

Re: dependabot madness

2025-07-05 Thread Gary Gregory
Wow, at bit over the top there Oleg IMO. This was a low-hanging fruit I saw and took care of it. Gary On Sat, Jul 5, 2025, 05:31 Oleg Kalnichevski wrote: > Gary et al > > Could we stop merging those dependabot pull requests every time they pop > up? Especially for test and optional dependencies

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17998270#comment-17998270 ] yhzdys commented on HTTPCLIENT-2379: There's also another case that might be ove

Re: [PR] Fix `validateAfterInactivity` on the async client [httpcomponents-client]

2025-07-05 Thread via GitHub
ok2c commented on code in PR #667: URL: https://github.com/apache/httpcomponents-client/pull/667#discussion_r2186982426 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java: ## @@ -315,10 +315,6 @@ public void completed(final

dependabot madness

2025-07-05 Thread Oleg Kalnichevski
Gary et al Could we stop merging those dependabot pull requests every time they pop up? Especially for test and optional dependencies? Please! Did we really need 3 upgrades of JUnit in the past 30 days? Now the commit log is filled with noise from dependabot and "Document dependency bumps" c

[jira] [Commented] (HTTPCLIENT-2381) Allow environment proxy settings by default or strongly document this decision

2025-07-05 Thread Jon Harper (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997090#comment-17997090 ] Jon Harper commented on HTTPCLIENT-2381: Hi, Thanks for taking the time to a

[jira] [Commented] (HTTPCLIENT-2381) Allow environment proxy settings by default or strongly document this decision

2025-07-05 Thread Jon Harper (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997091#comment-17997091 ] Jon Harper commented on HTTPCLIENT-2381: Also feel free to close this if tha

Re: [DISCUSS] Migrate from Jira to GitHub for issue tracking?

2025-07-05 Thread Gary Gregory
I'm ok either way. Gary On Sat, Jul 5, 2025, 12:08 Oleg Kalnichevski wrote: > Folks > > How would feel about the idea of migrating off Jira to GitHub for > project issue tracking? > > We do not use any of Jira's advanced project management functionality. > We need a simple issue tracker that in

Re: dependabot madness

2025-07-05 Thread Arturo Bernal
Gary, Merging every Dependabot bump for test/optional deps just clutters our history, spams CI/IDEs and brings no real value. Please only merge them in sync with our release cycle or when they address an actual issue. Arturo On Sat, Jul 5, 2025 at 1:11 PM Oleg Kalnichevski wrote: > > On 2025

Re: [DISCUSS] Migrate from Jira to GitHub for issue tracking?

2025-07-05 Thread Arturo Bernal
Oleg, I’m Ok on moving our issue tracking to GitHub Issues—simpler setup, unified notifications, and tighter PR integration. I’m happy to help with the migration (exports, label/milestone setup, testing, whatever’s needed). Just send me a message Cheers, Arturo On Sat, Jul 5, 2025 at 6:08 PM

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17999322#comment-17999322 ] Oleg Kalnichevski commented on HTTPCLIENT-2379: --- [~yhzdys] Could you p

Re: dependabot madness

2025-07-05 Thread Oleg Kalnichevski
On 2025-07-05 13:02, Gary Gregory wrote: Wow, at bit over the top there Oleg IMO. This was a low-hanging fruit I saw and took care of it. Gary The cause  of the problem appears to have been IntelliJ, not JUnit upgrade. My request still stands, however. Please, merge dependabot PRs for test

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997759#comment-17997759 ] yhzdys commented on HTTPCLIENT-2379: [~olegk]  I haven't tested this patch in m

Re: [PR] Replace the old InputStreamFactory registries with the new Decoder / Encoder pipeline [httpcomponents-client]

2025-07-05 Thread via GitHub
arturobernalg commented on code in PR #660: URL: https://github.com/apache/httpcomponents-client/pull/660#discussion_r2187194250 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/compress/Decoder.java: ## @@ -0,0 +1,60 @@ +/* + * ===

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997758#comment-17997758 ] yhzdys commented on HTTPCLIENT-2379: {quote}[~yhzdys] Could you please try it ou

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-05 Thread via GitHub
arturobernalg closed pull request #663: HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool URL: https://github.com/apache/httpcomponents-client/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997767#comment-17997767 ] Arturo Bernal commented on HTTPCLIENT-2379: --- [~olegk]  Added an {{isOpen(

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-05 Thread via GitHub
ok2c commented on code in PR #663: URL: https://github.com/apache/httpcomponents-client/pull/663#discussion_r2187372220 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/H2SharingConnPool.java: ## @@ -288,20 +290,14 @@ PoolEntry lease() { long release(fi

Re: [PR] Jep380SocketChannelAdapter: Connect in blocking mode [httpcomponents-client]

2025-07-05 Thread via GitHub
rschmitt merged PR #671: URL: https://github.com/apache/httpcomponents-client/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: [PR] Fix `validateAfterInactivity` on the async client [httpcomponents-client]

2025-07-05 Thread via GitHub
rschmitt merged PR #667: URL: https://github.com/apache/httpcomponents-client/pull/667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997760#comment-17997760 ] yhzdys commented on HTTPCLIENT-2379: Maybe we should consider adding a `usable`

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17998376#comment-17998376 ] Oleg Kalnichevski commented on HTTPCLIENT-2379: --- [~yhzdys] Another goo

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-05 Thread via GitHub
arturobernalg commented on code in PR #663: URL: https://github.com/apache/httpcomponents-client/pull/663#discussion_r2187431291 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/H2SharingConnPool.java: ## @@ -288,20 +290,14 @@ PoolEntry lease() { long r

[DISCUSS] Migrate from Jira to GitHub for issue tracking?

2025-07-05 Thread Oleg Kalnichevski
Folks How would feel about the idea of migrating off Jira to GitHub for project issue tracking? We do not use any of Jira's advanced project management functionality. We need a simple issue tracker that integrates well with GitHub. That is all. Now, whenever there is a dependabot version b

[PR] Jep380SocketChannelAdapter: Connect in blocking mode [httpcomponents-client]

2025-07-05 Thread via GitHub
rschmitt opened a new pull request, #671: URL: https://github.com/apache/httpcomponents-client/pull/671 This fixes UDS integration test failures on Windows and Java 17+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fix `validateAfterInactivity` on the async client [httpcomponents-client]

2025-07-05 Thread via GitHub
rschmitt commented on code in PR #667: URL: https://github.com/apache/httpcomponents-client/pull/667#discussion_r2186902254 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java: ## @@ -315,10 +315,6 @@ public void completed(f

[jira] [Updated] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-2379: -- Attachment: HTTPCLIENT-2379__release_of_closed___ivalid_pool_entries_by_H2

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997752#comment-17997752 ] Oleg Kalnichevski commented on HTTPCLIENT-2379: --- [^HTTPCLIENT-2379__re

[jira] [Commented] (HTTPCLIENT-2381) Allow environment proxy settings by default or strongly document this decision

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17997190#comment-17997190 ] Oleg Kalnichevski commented on HTTPCLIENT-2381: --- [~jonenst] My respons

[jira] [Updated] (HTTPCLIENT-2381) Allow environment proxy settings by default or strongly document this decision

2025-07-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-2381: -- Fix Version/s: Stuck Labels: volunteers-wanted (was: )

[jira] [Commented] (HTTPCLIENT-2379) Multiple removal of same PoolEntry causes IllegalStateException in H2SharingConnPool

2025-07-05 Thread yhzdys (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17999737#comment-17999737 ] yhzdys commented on HTTPCLIENT-2379: [~olegk]  I've tested this [PR|https://gith

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-05 Thread via GitHub
yhzdys commented on code in PR #663: URL: https://github.com/apache/httpcomponents-client/pull/663#discussion_r2187972350 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/H2SharingConnPool.java: ## @@ -270,16 +270,18 @@ long track(final PoolEntry entry) {

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-05 Thread via GitHub
yhzdys commented on code in PR #663: URL: https://github.com/apache/httpcomponents-client/pull/663#discussion_r2187972350 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/H2SharingConnPool.java: ## @@ -270,16 +270,18 @@ long track(final PoolEntry entry) {

Re: [PR] HTTPCLIENT-2379 - Handle duplicate release() safely in H2SharingConnPool [httpcomponents-client]

2025-07-05 Thread via GitHub
yhzdys commented on code in PR #663: URL: https://github.com/apache/httpcomponents-client/pull/663#discussion_r2187972350 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/H2SharingConnPool.java: ## @@ -270,16 +270,18 @@ long track(final PoolEntry entry) {