rschmitt commented on code in PR #667:
URL:
https://github.com/apache/httpcomponents-client/pull/667#discussion_r2186902254
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java:
##########
@@ -315,10 +315,6 @@ public void completed(final PoolEntry<HttpRoute,
ManagedAsyncClientConnection> p
})), Command.Priority.IMMEDIATE);
return;
Review Comment:
Won't that cause `leaseCompleted(poolEntry)` to be called immediately (line
321) after the PingCommand is submitted, and then a second time after the
PingCommand finishes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
