Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796695808 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796695808 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1797228784 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Properly alert receivers when using non-default dynamic table sizes for HPACK [httpcomponents-core]

CelestiaTheDryad commented on PR #495: URL: https://github.com/apache/httpcomponents-core/pull/495#issuecomment-2408108388 Added unit tests for several behaviors relating to dynamic table size and the size change signal. This includes one logical change to the encoder, replacing a `M

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

michael-o commented on PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2408150612 > I use TextContainers elsewhere, works like champ! TextContainers for sure... :-D -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Move HTTP/2 illegal message header check from message converters to protocol interceptors [httpcomponents-core]

ok2c commented on PR #496: URL: https://github.com/apache/httpcomponents-core/pull/496#issuecomment-2407493121 @arturobernalg Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796768944 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

massdosage commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796699503 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * ===

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

ok2c commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796927426 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * =

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

ok2c commented on PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#issuecomment-2407892866 If there are no further comments I will merge this PR as there is a few others that depend on it. -- This is an automated message from the Apache Git Service. To respond to the

[PR] Return builder from setHostnameVerificationPolicy [httpcomponents-client]

osipxd opened a new pull request, #588: URL: https://github.com/apache/httpcomponents-client/pull/588 Currently, it is impossible to add `setHostnameVerificationPolicy` to a call chain -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Return builder from setHostnameVerificationPolicy [httpcomponents-client]

ok2c commented on PR #588: URL: https://github.com/apache/httpcomponents-client/pull/588#issuecomment-2407762314 @osipxd Damn. This is an API breaking change. We will have to deprecate this method and add another one with a different name. What is even more worrisome is the API breakage ha

Re: [PR] Properly alert receivers when using non-default dynamic table sizes for HPACK [httpcomponents-core]

CelestiaTheDryad commented on code in PR #495: URL: https://github.com/apache/httpcomponents-core/pull/495#discussion_r1797260953 ## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackEncoder.java: ## @@ -261,6 +262,11 @@ void encodeHeader( void encodeHeader(

[PR] Bump com.googlecode.maven-download-plugin:download-maven-plugin from 1.9.0 to 1.10.0 [httpcomponents-client]

dependabot[bot] opened a new pull request, #587: URL: https://github.com/apache/httpcomponents-client/pull/587 Bumps [com.googlecode.maven-download-plugin:download-maven-plugin](https://github.com/maven-download-plugin/maven-download-plugin) from 1.9.0 to 1.10.0. Release notes Sou

Re: [PR] Migrated Docker based integration tests to TestContainers [httpcomponents-core]

ok2c commented on code in PR #494: URL: https://github.com/apache/httpcomponents-core/pull/494#discussion_r1796738752 ## httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/ContainerImages.java: ## @@ -0,0 +1,94 @@ +/* + * =

Re: [PR] Properly alert receivers when using non-default dynamic table sizes for HPACK [httpcomponents-core]

ok2c commented on code in PR #495: URL: https://github.com/apache/httpcomponents-core/pull/495#discussion_r1797074801 ## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackEncoder.java: ## @@ -261,6 +262,11 @@ void encodeHeader( void encodeHeader(