CelestiaTheDryad commented on code in PR #495: URL: https://github.com/apache/httpcomponents-core/pull/495#discussion_r1797260953
########## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackEncoder.java: ########## @@ -261,6 +262,11 @@ void encodeHeader( void encodeHeader( final ByteArrayBuffer dst, final String name, final String value, final boolean sensitive, final boolean noIndexing, final boolean useHuffman) throws CharacterCodingException { + //send receiver the updated dynamic table size + if (maxTableSize != this.dynamicTable.getMaxSize()) { Review Comment: I'll add some unit tests today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org