arturobernalg commented on PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#issuecomment-2371320422
> > > I think we should use a builder for ContenType instead of piling on
constructors or factory methods.
> >
> >
> > HI @garydgregory That seems like a massiv
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Plotnick updated HTTPCLIENT-2344:
-
Component/s: HttpClient (classic)
(was: HttpCache)
> HTTP/1.1 T
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884330#comment-17884330
]
Ben Plotnick commented on HTTPCLIENT-2344:
--
{quote}IMO We should strictly f
arturobernalg commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1773414411
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370743858
@garydgregory I already have a fix for the problem. I can adjust the
change-set if it is fine with you.
--
This is an automated message from the Apache Git Service.
To respond t
Folks
Please review the change-log of the coming HC Parent 14 release:
https://github.com/apache/httpcomponents-parent/blob/master/pom.xml
Oleg
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e
garydgregory merged PR #485:
URL: https://github.com/apache/httpcomponents-core/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
garydgregory commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370800473
Hi @ok2c
I am ok with breaking source compatibility but obviously not binary
compatibility. If you feel source compatibility is important in this case,
then, yeah, som
ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370807268
@garydgregory I do not think breakage of compile compatibility is warranted
here. Once `hc-parent` is upgraded a newer version of `japicmp` will no longer
let the build to pass in
arturobernalg commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1773349720
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
arturobernalg commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1773363903
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1773392198
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski updated HTTPCLIENT-2344:
--
Fix Version/s: 5.4.1
Priority: Minor (was: Major)
> HTTP/1.1 TLS
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884355#comment-17884355
]
Oleg Kalnichevski commented on HTTPCLIENT-2344:
---
> Servers are not obl
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884420#comment-17884420
]
Gary D. Gregory commented on HTTPCLIENT-2344:
-
I agree that there is no
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884323#comment-17884323
]
Arturo Bernal commented on HTTPCLIENT-2344:
---
IMO We should strictly follow
arturobernalg commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1773414963
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
Ben Plotnick created HTTPCLIENT-2344:
Summary: HTTP/1.1 TLS Upgrade (RFC-2817) should not be default
Key: HTTPCLIENT-2344
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2344
Project: HttpCom
bplotnick commented on PR #542:
URL:
https://github.com/apache/httpcomponents-client/pull/542#issuecomment-2371530662
This caused https://issues.apache.org/jira/browse/HTTPCLIENT-2344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884346#comment-17884346
]
Arturo Bernal commented on HTTPCLIENT-2344:
---
I still don’t see any issue h
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884320#comment-17884320
]
Oleg Kalnichevski commented on HTTPCLIENT-2344:
---
> I don't see a big a
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1773395960
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370726252
@garydgregory According to the latest `japicmp` this change-set broke
backward (compile) compatibility.
```
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japi
garydgregory opened a new pull request, #485:
URL: https://github.com/apache/httpcomponents-core/pull/485
I do not think it makes sense to build a new FutureContribution with a null
callback.
This does not happen in the current code base.
--
This is an automated message from th
24 matches
Mail list logo
