arturobernalg commented on PR #483: URL: https://github.com/apache/httpcomponents-core/pull/483#issuecomment-2371320422
> > > I think we should use a builder for ContenType instead of piling on constructors or factory methods. > > > > > > HI @garydgregory That seems like a massive change. Maybe we can consider a full refactor of the class in another ticket? I'm not sure if it's necessary right now compared to the charset ContentType parameter handling. > > Hi @arturobernalg Whatever the scale of the change it kind of feels like the right time to do it IMO _because_ we are taking of new factory methods/construction. > > I do take your point that it could be done in a separate PR _if_ that PR happens first. If we agree on implementing a builder, I can volunteer to do it unless you'd rather do it. HI @garydgregory If we agree on implementing a builder, I will do it. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
