[ https://issues.apache.org/jira/browse/HTTPCLIENT-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884320#comment-17884320 ]
Oleg Kalnichevski commented on HTTPCLIENT-2344: ----------------------------------------------- > I don't see a big advantage to enabling this by default and it is causing > real issues now. [~bplotnick] Any half-decent HTTP server or proxy should be able to handle `Upgrade` and ignore those upgrade protocols they do not support / understand. I do not see why this option should be disabled by default because of some overzealous proxy? Please provide a full wire log of the session with that proxy. Oleg > HTTP/1.1 TLS Upgrade (RFC-2817) should not be default > ----------------------------------------------------- > > Key: HTTPCLIENT-2344 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2344 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient (classic) > Affects Versions: 5.4 > Reporter: Ben Plotnick > Priority: Minor > Fix For: 5.4.1 > > > Version 5.4 added RFC-2817 support, which by default tries to upgradeĀ since > protocolUpgradeEnabled is default enabled. > Although the strict reading of the spec would indicate that a server should > ignore upgrade requests that it cannot service, conservative proxies might > reject these requests entirely. This is the case in Envoy today > I don't see a big advantage to enabling this by default and it is causing > real issues now. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org