garydgregory opened a new pull request, #484:
URL: https://github.com/apache/httpcomponents-core/pull/484
- Reduces boilerplate when the same pattern is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1771184701
##
httpcore5/src/test/java/org/apache/hc/core5/http/TestContentType.java:
##
@@ -183,4 +183,143 @@ void testWithParams() throws Exception {
Assert
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1771188233
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -214,6 +236,18 @@ public final class ContentType implements Serializable {
The vote to release HttpComponents StyleCheck 3 based on RC1 has passed
with the following results
+1 (2 binding votes in total)
Oleg Kalnichevski *
Arturo Bernal *
no other votes
* binding votes
Original voting thread:
https://lists.apache.org/thread/8ylp9t1vcsst3ngprlmz6npv2lz55lg4
---
ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2368918076
@garydgregory Looks good. Please re-apply with the latest style checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
The Apache HttpComponents project is pleased to announce 5.4 release of
HttpComponents HttpClient.
This is the first GA release in the 5.4 release series. This release
finalizes the 5.4 APIs, upgrades HttpCore to version 5.3 and improves
the Public Suffix matching algorithm implementation.
IMPORT
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Winfried Gerlach updated HTTPCLIENT-2337:
-
Labels: (was: volunteers-wanted)
> Potentially unsafe logging of X500Princ
garydgregory merged PR #484:
URL: https://github.com/apache/httpcomponents-core/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
garydgregory commented on PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#issuecomment-2369323519
> > I think we should use a builder for ContenType instead of piling on
constructors or factory methods.
>
> HI @garydgregory That seems like a massive change. Maybe
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1772049067
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1772057511
##
httpcore5/src/test/java/org/apache/hc/core5/http/TestContentType.java:
##
@@ -183,4 +183,132 @@ void testWithParams() throws Exception {
Assert
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1772051216
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -67,105 +68,125 @@ public final class ContentType implements Serializable {
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1772056433
##
httpcore5/src/test/java/org/apache/hc/core5/http/TestContentType.java:
##
@@ -183,4 +183,132 @@ void testWithParams() throws Exception {
Assert
arturobernalg commented on PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#issuecomment-2369275504
> I think we should use a builder for ContenType instead of piling on
constructors or factory methods.
HI @garydgregory
That seems like a massive change. Maybe
arturobernalg commented on PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#issuecomment-2369274855
> This PR does not put the description on the MIME types into consideration
pointed out in HTTPCLIENT-2159.
HI @michael-o
Please do another pass. I think we’ve
michael-o commented on PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#issuecomment-2369276568
> > This PR does not put the description on the MIME types into
consideration pointed out in HTTPCLIENT-2159.
>
> HI @michael-o Please do another pass. I think we’ve co
michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1772063397
##
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##
@@ -326,7 +432,9 @@ public static ContentType create(final String mimeType,
final
17 matches
Mail list logo
