michael-o commented on code in PR #483:
URL:
https://github.com/apache/httpcomponents-core/pull/483#discussion_r1771188233
##########
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##########
@@ -214,6 +236,18 @@ public final class ContentType implements Serializable {
CONTENT_TYPE_MAP = Collections.unmodifiableMap(map);
}
+ // List of media types that should not include charset
+ private static final List<String> NO_CHARSET_TYPES =
Collections.unmodifiableList(Arrays.asList(
Review Comment:
I wouldn't maintain such a like because it can never be exhaustive. We have
some predefines and they should carry metadata. If a client creates a custom
content type it is his obligation to provide this information, no?
##########
httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java:
##########
Review Comment:
PDF is not text. It is a binary format. The charset should be dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
