michael-o commented on code in PR #483: URL: https://github.com/apache/httpcomponents-core/pull/483#discussion_r1772063397
########## httpcore5/src/main/java/org/apache/hc/core5/http/ContentType.java: ########## @@ -326,7 +432,9 @@ public static ContentType create(final String mimeType, final Charset charset) { * @param mimeType MIME type. It may not be {@code null} or empty. It may not contain * characters {@code <">, <;>, <,>} reserved by the HTTP specification. * @return content type + * @deprecated Use {@link #create(String, Charset, boolean)} with an explicit charset or null, and specify if the charset is implicit. */ + @Deprecated Review Comment: Why deprecate a short-hand ctor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org