Mass Dosage created HTTPCLIENT-2336:
---
Summary: Update PublicSuffixMatcher to use "formal algorithm"
Key: HTTPCLIENT-2336
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2336
Project: HttpCompon
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mass Dosage updated HTTPCLIENT-2336:
Description:
We’ve been using the {{PublicSuffixMatcher}} component from
“httpcompone
massdosage opened a new pull request, #566:
URL: https://github.com/apache/httpcomponents-client/pull/566
See https://issues.apache.org/jira/browse/HTTPCLIENT-2336 for context.
After porting over the tests for the formal algorithm from
https://github.com/publicsuffix/list/blob/master/
massdosage commented on code in PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#discussion_r1718196054
##
httpclient5/src/test/java/org/apache/hc/client5/http/impl/cookie/TestPublicSuffixListParser.java:
##
@@ -111,7 +111,7 @@ void testParseLocal() {
massdosage commented on code in PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#discussion_r1718197205
##
httpclient5/src/test/java/org/apache/hc/client5/http/ssl/TestDefaultHostnameVerifier.java:
##
@@ -258,11 +259,11 @@ void testIdentityMatching() {
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873874#comment-17873874
]
Mass Dosage commented on HTTPCLIENT-2336:
-
Pull request showing a possible w
ok2c commented on PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2291081455
> I'm wondering if the legacy mode should be an enum instead of a boolean.
@massdosage Let's simplify things. I do not think we need to preserve the
old legacy behavior,
massdosage commented on PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2291221238
@garydgregory @ok2c thanks for the prompt initial review. I've removed the
`legacyMode` parameter as requested.
--
This is an automated message from the Apache Git Servi
garydgregory opened a new pull request, #476:
URL: https://github.com/apache/httpcomponents-core/pull/476
Implement the "len" part of contract for `java.io.InputStream.read(byte[],
int, int)`
- If `len` is zero, then no bytes are read and 0 is returned.
- Be explicit like we are fo
