Mass Dosage created HTTPCLIENT-2336:
---------------------------------------
Summary: Update PublicSuffixMatcher to use "formal algorithm"
Key: HTTPCLIENT-2336
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2336
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpClient (classic)
Reporter: Mass Dosage
Fix For: Future
We’ve been using the {{PublicSuffixMatcher}} component from
“httpcomponents-client” to implement comparisons of domains and public suffixes
according to the rules defined by the standard at
[https://github.com/publicsuffix/list/wiki/Format#formal-algorithm|https://github.com/publicsuffix/list/wiki/Format#formal-algorithm]and
using the Public Suffix List produced by Mozilla at
[https://publicsuffix.org/list/effective_tld_names.dat|https://publicsuffix.org/list/effective_tld_names.dat].
We noticed unexpected results where the current behaviour of
{{PublicSuffixMatcher}} deviates from the formal algorithm. We ported over the
unit tests from
[https://github.com/publicsuffix/list/blob/master/tests/test_psl.txt|https://github.com/publicsuffix/list/blob/master/tests/test_psl.txt]
to determine all the differences as there are a number of tests which fail.
This follows on from an earlier discussion on the mailing list at
[https://lists.apache.org/thread/ylom7gcopxtrcb4zm6q8c9k7fo0jt5km|https://lists.apache.org/thread/ylom7gcopxtrcb4zm6q8c9k7fo0jt5km].
We have made changes to get all the tests to pass and will raise a PR shortly
to reference this ticket.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
