massdosage commented on code in PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#discussion_r1718196054
##########
httpclient5/src/test/java/org/apache/hc/client5/http/impl/cookie/TestPublicSuffixListParser.java:
##########
@@ -111,7 +111,7 @@ void testParseLocal() {
cookie.setDomain(".blah");
cookie.setAttribute(Cookie.DOMAIN_ATTR, ".blah");
- Assertions.assertTrue(filter.match(cookie, new
CookieOrigin("somehost.blah", 80, "/stuff", false)));
+ Assertions.assertFalse(filter.match(cookie, new
CookieOrigin("somehost.blah", 80, "/stuff", false)));
Review Comment:
One shouldn't be allowed to set a cookie for the "blah" TLD as this is a
potential security risk so we inverted the assertion as we believe the new
behaviour is more secure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
